Skip to content

Commit 171cebb

Browse files
ref: get proper base manager typing
1 parent 33f55ff commit 171cebb

File tree

1 file changed

+7
-2
lines changed
  • src/sentry/db/models/manager

1 file changed

+7
-2
lines changed

src/sentry/db/models/manager/base.py

+7-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from collections.abc import Callable, Collection, Generator, Mapping, MutableMapping, Sequence
77
from contextlib import contextmanager
88
from enum import IntEnum, auto
9-
from typing import Any, Generic
9+
from typing import TYPE_CHECKING, Any
1010

1111
from django.conf import settings
1212
from django.db import models, router
@@ -42,8 +42,13 @@ class ModelManagerTriggerCondition(IntEnum):
4242

4343
ModelManagerTriggerAction = Callable[[type[Model]], None]
4444

45+
if TYPE_CHECKING:
46+
_base_manager_base = DjangoBaseManager[M]
47+
else:
48+
_base_manager_base = DjangoBaseManager.from_queryset(BaseQuerySet)
4549

46-
class BaseManager(DjangoBaseManager.from_queryset(BaseQuerySet), Generic[M]): # type: ignore[misc]
50+
51+
class BaseManager(_base_manager_base[M]):
4752
lookup_handlers = {"iexact": lambda x: x.upper()}
4853
use_for_related_fields = True
4954

0 commit comments

Comments
 (0)