ref: remove nullability of default_identity (#89734)

<!-- Describe your PR here. -->

Author: asottile-sentry

src/sentry/integrations/base.py

@@ -436,7 +436,8 @@ def get_keyring_client(self, keyid: int | str) -> Any:
         """
         raise NotImplementedError
 
-    def get_default_identity(self) -> RpcIdentity:
+    @cached_property
+    def default_identity(self) -> RpcIdentity:
         """For Integrations that rely solely on user auth for authentication."""
         try:
             org_integration = self.org_integration

src/sentry/integrations/bitbucket_server/integration.py

@@ -244,23 +244,18 @@ class BitbucketServerIntegration(RepositoryIntegration):
     IntegrationInstallation implementation for Bitbucket Server
     """
 
-    default_identity = None
-
     @property
     def integration_name(self) -> str:
         return "bitbucket_server"
 
-    def get_client(self):
-        if self.default_identity is None:
-            try:
-                self.default_identity = self.get_default_identity()
-            except Identity.DoesNotExist:
-                raise IntegrationError("Identity not found.")
-
-        return BitbucketServerClient(
-            integration=self.model,
-            identity=self.default_identity,
-        )
+    def get_client(self) -> BitbucketServerClient:
+        try:
+            return BitbucketServerClient(
+                integration=self.model,
+                identity=self.default_identity,
+            )
+        except Identity.DoesNotExist:
+            raise IntegrationError("Identity not found.")
 
     # IntegrationInstallation methods
 

src/sentry/integrations/gitlab/client.py

@@ -87,7 +87,7 @@ def __init__(self, installation: GitlabIntegration):
     def identity(self) -> RpcIdentity:
         if self.refreshed_identity:
             return self.refreshed_identity
-        return self.installation.get_default_identity()
+        return self.installation.default_identity
 
     @property
     def metadata(self):

src/sentry/integrations/gitlab/integration.py

@@ -98,22 +98,18 @@
 class GitlabIntegration(RepositoryIntegration, GitlabIssuesSpec, CommitContextIntegration):
     codeowners_locations = ["CODEOWNERS", ".gitlab/CODEOWNERS", "docs/CODEOWNERS"]
 
-    def __init__(self, *args, **kwargs):
-        super().__init__(*args, **kwargs)
-        self.default_identity = None
-
     @property
     def integration_name(self) -> str:
         return "gitlab"
 
-    def get_client(self):
-        if self.default_identity is None:
-            try:
-                self.default_identity = self.get_default_identity()
-            except Identity.DoesNotExist:
-                raise IntegrationError("Identity not found.")
-
-        return GitLabApiClient(self)
+    def get_client(self) -> GitLabApiClient:
+        try:
+            # eagerly populate this just for the error message
+            self.default_identity
+        except Identity.DoesNotExist:
+            raise IntegrationError("Identity not found.")
+        else:
+            return GitLabApiClient(self)
 
     # IntegrationInstallation methods
     def error_message_from_json(self, data):

src/sentry/integrations/jira_server/integration.py

@@ -334,19 +334,12 @@ class JiraServerIntegration(IssueSyncIntegration):
     issues_ignored_fields_key = "issues_ignored_fields"
     resolution_strategy_key = "resolution_strategy"
 
-    default_identity = None
-
     def get_client(self):
         try:
-            self.default_identity = self.get_default_identity()
+            return JiraServerClient(integration=self.model, identity=self.default_identity)
         except Identity.DoesNotExist:
             raise IntegrationError("Identity not found.")
 
-        return JiraServerClient(
-            integration=self.model,
-            identity=self.default_identity,
-        )
-
     def get_organization_config(self):
         configuration: list[_Config] = [
             {

src/sentry/integrations/vsts/integration.py

@@ -130,19 +130,13 @@ class VstsIntegration(RepositoryIntegration, VstsIssuesSpec):
     outbound_assignee_key = "sync_forward_assignment"
     inbound_assignee_key = "sync_reverse_assignment"
 
-    def __init__(self, *args: Any, **kwargs: Any) -> None:
-        super().__init__(*args, **kwargs)
-        self.default_identity: RpcIdentity | None = None
-
     @property
     def integration_name(self) -> str:
         return "vsts"
 
     def get_client(self) -> VstsApiClient:
         base_url = self.instance
         if SiloMode.get_current_mode() != SiloMode.REGION:
-            if self.default_identity is None:
-                self.default_identity = self.get_default_identity()
             self._check_domain_name(self.default_identity)
 
         if self.org_integration is None:

tests/sentry/integrations/gitlab/test_client.py

@@ -178,7 +178,7 @@ def test_check_file(self):
 
         resp = self.gitlab_client.check_file(self.repo, path, ref)
         assert responses.calls[0].response.status_code == 200
-        assert resp.status_code == 200
+        assert resp  # this is None on error
 
     @responses.activate
     def test_check_no_file(self):

tests/sentry/integrations/test_base.py

@@ -40,11 +40,11 @@ def test_with_context(self):
         assert integration.model.id == self.model.id
         assert integration.org_integration is not None
         assert integration.org_integration.id == self.org_integration.id
-        assert integration.get_default_identity() == serialize_identity(self.identity)
+        assert integration.default_identity == serialize_identity(self.identity)
 
     def test_missing_org_integration(self):
         with pytest.raises(Identity.DoesNotExist):
-            ExampleIntegration(self.model, -1).get_default_identity()
+            ExampleIntegration(self.model, -1).default_identity
 
     def test_model_default_fields(self):
         # These fields are added through the DefaultFieldsModel