Skip to content

Investigate and fix suggested feedback search fields #88766

Open
@aliu39

Description

@aliu39

I noticed a lot of our suggested fields in the feedback search bar don't work as expected, or not at all. Others have no suggested values.

Notes how the search bar works:

  • all suggested values are queried from OrganizationTagKeyValuesEndpoint, issue platform dataset, regardless of whether the field is a tag (e.g. message is not a tag).
  • the "suggested" section is hard-coded by us. Custom tags will show up in "tags", so if a field is always suggested we should make sure the search works, and is useful.
    Image

Fields:

  • assigned: not a tag. Filter works but don't get any suggestions, even when I assign to myself (me, #replay..). Look into how issues does suggestions.

  • browser.version: tag. It's not suggested by issues search bar, and I suspect search hasn't been implemented by the backend.

  • Search doesn't work and no suggestions returned.

  • = "" returns all, not = "" returns none.

  • device.model_id: we suggest this but the actual tag is device.model.

  • For both, search doesn't work, and no suggestions

  • For model_id: = "" returns none

  • For model: = "" returns all

  • message: not a tag. Works w/the complete string (case insensitive), but need to support wildcard *.

  • Suggestions were removed in ref(feedback): clean up search suggestion fields #87949 since it was showing unrelated error messages.

  • Useful to have feedback-specific suggestions, but good deal of effort in the backend

  • platform: tag. Filter doesn't work and I only get suggestions when selecting all projects. Replacing this with platform.name seems like the fix (accurate suggestions and filter).

Untested:

  • locale.lang
  • locale.timezone
    Not very common, maybe we don't need to suggest. Not sure if these are tags.

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions