Skip to content

Commit 28f388f

Browse files
committed
upload-pack: no longer use hidden-refs as exclude_patterns
1 parent 08bdfd4 commit 28f388f

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

Diff for: upload-pack.c

+3-12
Original file line numberDiff line numberDiff line change
@@ -609,21 +609,12 @@ static int allow_hidden_refs(enum allow_uor allow_uor)
609609
static void for_each_namespaced_ref_1(each_ref_fn fn,
610610
struct upload_pack_data *data)
611611
{
612-
const char **excludes = NULL;
613612
/*
614-
* If `data->allow_uor` allows fetching hidden refs, we need to
615-
* mark all references (including hidden ones), to check in
616-
* `is_our_ref()` below.
617-
*
618-
* Otherwise, we only care about whether each reference's object
619-
* has the OUR_REF bit set or not, so do not need to visit
620-
* hidden references.
613+
* config transfer.hideRefs of upload-pack is diffient from arg exclude of for-each-ref,
614+
* We should not set exclude_patterns here
621615
*/
622-
if (allow_hidden_refs(data->allow_uor))
623-
excludes = hidden_refs_to_excludes(&data->hidden_refs);
624-
625616
refs_for_each_namespaced_ref(get_main_ref_store(the_repository),
626-
excludes, fn, data);
617+
NULL, fn, data);
627618
}
628619

629620

0 commit comments

Comments
 (0)