filter not supported give error

Signed-off-by: John Giorshev <john.giorshev1@gmail.com>

Author: jagprog5

Diff for: fetch-pack.c

@@ -319,9 +319,7 @@ static void send_filter(struct fetch_pack_args *args,
 			trace2_data_string("fetch", the_repository,
 					   "filter/effective", spec);
 		} else {
-			warning("filtering not recognized by server, ignoring");
-			trace2_data_string("fetch", the_repository,
-					   "filter/unsupported", spec);
+			die("filtering not recognized by server");
 		}
 	} else {
 		trace2_data_string("fetch", the_repository,

Diff for: t/t0410-partial-clone.sh

@@ -36,42 +36,8 @@ test_expect_success 'extensions.partialclone without filter' '
 	git -C client fetch origin
 '
 
-test_expect_success 'convert shallow clone to partial clone' '
-	rm -fr server client &&
-	test_create_repo server &&
-	test_commit -C server my_commit 1 &&
-	test_commit -C server my_commit2 1 &&
-	git clone --depth=1 "file://$(pwd)/server" client &&
-	git -C client fetch --unshallow --filter="blob:none" &&
-	test_cmp_config -C client true remote.origin.promisor &&
-	test_cmp_config -C client blob:none remote.origin.partialclonefilter &&
-	test_cmp_config -C client 1 core.repositoryformatversion
-'
-
-test_expect_success DEFAULT_REPO_FORMAT 'convert to partial clone with noop extension' '
-	rm -fr server client &&
-	test_create_repo server &&
-	test_commit -C server my_commit 1 &&
-	test_commit -C server my_commit2 1 &&
-	git clone --depth=1 "file://$(pwd)/server" client &&
-	test_cmp_config -C client 0 core.repositoryformatversion &&
-	git -C client config extensions.noop true &&
-	git -C client fetch --unshallow --filter="blob:none"
-'
-
-test_expect_success DEFAULT_REPO_FORMAT 'converting to partial clone fails with unrecognized extension' '
-	rm -fr server client &&
-	test_create_repo server &&
-	test_commit -C server my_commit 1 &&
-	test_commit -C server my_commit2 1 &&
-	git clone --depth=1 "file://$(pwd)/server" client &&
-	test_cmp_config -C client 0 core.repositoryformatversion &&
-	git -C client config extensions.nonsense true &&
-	test_must_fail git -C client fetch --unshallow --filter="blob:none"
-'
-
 test_expect_success 'missing reflog object, but promised by a commit, passes fsck' '
-	rm -rf repo &&
+	rm -rf server client &&
 	test_create_repo repo &&
 	test_commit -C repo my_commit &&
 
@@ -240,7 +206,7 @@ test_expect_success 'fetching of missing objects works with ref-in-want enabled'
 	grep "fetch< fetch=.*ref-in-want" trace
 '
 
-test_expect_success 'fetching from another promisor remote' '
+test_expect_success 'fetching of missing objects from another promisor remote' '
 	git clone "file://$(pwd)/server" server2 &&
 	test_commit -C server2 bar &&
 	git -C server2 repack -a -d --write-bitmap-index &&
@@ -263,32 +229,8 @@ test_expect_success 'fetching from another promisor remote' '
 	grep "$HASH2" out
 '
 
-test_expect_success 'fetching with --filter configures a promisor remote' '
-	test_create_repo server3 &&
-	test_commit -C server3 baz &&
-	git -C server3 repack -a -d --write-bitmap-index &&
-	HASH3=$(git -C server3 rev-parse baz) &&
-	git -C server3 config uploadpack.allowfilter 1 &&
-
-	rm repo/.git/objects/pack/pack-*.promisor &&
-
-	git -C repo remote add server3 "file://$(pwd)/server3" &&
-	git -C repo fetch --filter="blob:none" server3 $HASH3 &&
-
-	test_cmp_config -C repo true remote.server3.promisor &&
-
-	# Ensure that the .promisor file is written, and check that its
-	# associated packfile contains the object
-	ls repo/.git/objects/pack/pack-*.promisor >promisorlist &&
-	test_line_count = 1 promisorlist &&
-	IDX=$(sed "s/promisor$/idx/" promisorlist) &&
-	git verify-pack --verbose "$IDX" >out &&
-	grep "$HASH3" out
-'
-
 test_expect_success 'fetching of missing blobs works' '
 	rm -rf server server2 repo &&
-	rm -rf server server3 repo &&
 	test_create_repo server &&
 	test_commit -C server foo &&
 	git -C server repack -a -d --write-bitmap-index &&
@@ -776,6 +718,65 @@ test_expect_success 'fetching of missing objects from an HTTP server' '
 	grep "$HASH" out
 '
 
+test_expect_success 'convert shallow clone to partial clone' '
+	rm -rf repo &&
+	SERVER="$HTTPD_DOCUMENT_ROOT_PATH/server" &&
+	test_create_repo "$SERVER" &&
+	test_commit -C "$SERVER" my_commit 1 &&
+	test_commit -C "$SERVER" my_commit2 1 &&
+	git clone --depth=1 "$HTTPD_URL/smart/server" repo &&
+	git -C repo fetch --unshallow --filter="blob:none" &&
+	test_cmp_config -C repo true remote.origin.promisor &&
+	test_cmp_config -C repo blob:none remote.origin.partialclonefilter &&
+	test_cmp_config -C repo 1 core.repositoryformatversion
+'
+
+test_expect_success DEFAULT_REPO_FORMAT 'convert to partial clone with noop extension' '
+	rm -rf repo &&
+	SERVER="$HTTPD_DOCUMENT_ROOT_PATH/server" &&
+	test_create_repo "$SERVER" &&
+	test_commit -C "$SERVER" my_commit 1 &&
+	test_commit -C "$SERVER" my_commit2 1 &&
+	git clone --depth=1 "$HTTPD_URL/smart/server" repo &&
+	test_cmp_config -C repo 0 core.repositoryformatversion &&
+	git -C repo config extensions.noop true &&
+	git -C repo fetch --unshallow --filter="blob:none"
+'
+
+test_expect_success DEFAULT_REPO_FORMAT 'converting to partial clone fails with unrecognized extension' '
+	rm -rf repo &&
+	SERVER="$HTTPD_DOCUMENT_ROOT_PATH/server" &&
+	test_create_repo "$SERVER" &&
+	test_commit -C "$SERVER" my_commit 1 &&
+	test_commit -C "$SERVER" my_commit2 1 &&
+	git clone --depth=1 "$HTTPD_URL/smart/server" repo &&
+	test_cmp_config -C repo 0 core.repositoryformatversion &&
+	git -C repo config extensions.nonsense true &&
+	test_must_fail git -C repo fetch --unshallow
+'
+
+test_expect_success 'fetching of missing objects configures a promisor remote' '
+	rm -rf repo &&
+	git clone "$HTTPD_URL/smart/server" server3 &&
+	test_commit -C server3 baz &&
+	git -C server3 repack -a -d --write-bitmap-index &&
+	HASH3=$(git -C server3 rev-parse baz) &&
+	git -C server3 config uploadpack.allowfilter 1 &&
+
+	rm repo/.git/objects/pack/pack-*.promisor &&
+
+	git -C repo remote add server3 "$HTTPD_URL/smart/server3" &&
+	git -C repo fetch --filter="blob:none" server3 $HASH3 &&
+
+	test_cmp_config -C repo true remote.server3.promisor &&
+
+	ls repo/.git/objects/pack/pack-*.promisor >promisorlist &&
+	test_line_count = 1 promisorlist &&
+	IDX=$(sed "s/promisor$/idx/" promisorlist) &&
+	git verify-pack --verbose "$IDX" >out &&
+	grep "$HASH3" out
+'
+
 # DO NOT add non-httpd-specific tests here, because the last part of this
 # test script is only executed when httpd is available and enabled.