Skip to content

Commit 36457f6

Browse files
committed
JS: Update test output and add related TODO in model of 'async'
1 parent aea573b commit 36457f6

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

Diff for: javascript/ql/lib/semmle/javascript/frameworks/AsyncPackage.qll

+1-1
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ module AsyncPackage {
142142
override predicate step(DataFlow::Node pred, DataFlow::Node succ) {
143143
exists(DataFlow::FunctionNode iteratee, IterationCall call |
144144
iteratee = call.getIteratorCallback() and // Require a closure to avoid spurious call/return mismatch.
145-
pred = call.getCollection() and
145+
pred = call.getCollection() and // TODO: needs a flow summary to ensure ArrayElement content is unfolded
146146
succ = iteratee.getParameter(0)
147147
)
148148
}

Diff for: javascript/ql/test/library-tests/frameworks/AsyncPackage/AsyncTaintTracking.expected

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
legacyDataFlowDifference
2+
| each.js:11:9:11:16 | source() | each.js:13:12:13:15 | item | only flow with OLD data flow library |
3+
| map.js:10:13:10:20 | source() | map.js:12:14:12:17 | item | only flow with OLD data flow library |
4+
| map.js:26:13:26:20 | source() | map.js:28:27:28:32 | result | only flow with OLD data flow library |
5+
| sortBy.js:10:22:10:29 | source() | sortBy.js:12:27:12:32 | result | only flow with OLD data flow library |
26
#select
3-
| each.js:11:9:11:16 | source() | each.js:13:12:13:15 | item |
4-
| map.js:10:13:10:20 | source() | map.js:12:14:12:17 | item |
57
| map.js:20:19:20:26 | source() | map.js:23:27:23:32 | result |
6-
| map.js:26:13:26:20 | source() | map.js:28:27:28:32 | result |
7-
| sortBy.js:10:22:10:29 | source() | sortBy.js:12:27:12:32 | result |
88
| waterfall.js:8:30:8:37 | source() | waterfall.js:11:12:11:16 | taint |
99
| waterfall.js:8:30:8:37 | source() | waterfall.js:20:10:20:14 | taint |
1010
| waterfall.js:28:18:28:25 | source() | waterfall.js:39:10:39:12 | err |

0 commit comments

Comments
 (0)