Skip to content

Commit 4d75d88

Browse files
authored
Merge pull request #10733 from github/nickrolfe/deprecated_paramscall_fix
Ruby: fix use of deprecated class
2 parents be95b91 + a6674a5 commit 4d75d88

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

ruby/ql/lib/codeql/ruby/frameworks/ActionController.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,7 @@ private module ParamsSummaries {
392392
*/
393393
private class ParamsInstance extends DataFlow::Node {
394394
ParamsInstance() {
395-
this.asExpr().getExpr() instanceof ParamsCall
395+
this.asExpr().getExpr() instanceof Rails::ParamsCall
396396
or
397397
this =
398398
any(DataFlow::CallNode call |

ruby/ql/test/library-tests/frameworks/action_controller/params-flow.ql

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,12 @@
55
import ruby
66
import TestUtilities.InlineFlowTest
77
import PathGraph
8-
import codeql.ruby.frameworks.ActionController
8+
import codeql.ruby.frameworks.Rails
99

1010
class ParamsTaintFlowConf extends DefaultTaintFlowConf {
11-
override predicate isSource(DataFlow::Node n) { n.asExpr().getExpr() instanceof ParamsCall }
11+
override predicate isSource(DataFlow::Node n) {
12+
n.asExpr().getExpr() instanceof Rails::ParamsCall
13+
}
1214
}
1315

1416
from DataFlow::PathNode source, DataFlow::PathNode sink, ParamsTaintFlowConf conf

0 commit comments

Comments
 (0)