Skip to content

Commit b58e6eb

Browse files
committed
Address review comments for localTaintStep
1 parent 26b5207 commit b58e6eb

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

Diff for: go/ql/lib/semmle/go/dataflow/internal/TaintTrackingUtil.qll

+3-2
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ predicate localTaintStep(DataFlow::Node src, DataFlow::Node sink) {
3737
or
3838
// Treat container flow as taint for the local taint flow relation
3939
exists(DataFlow::Content c | DataFlowPrivate::containerContent(c) |
40-
DataFlowPrivate::readStep(src, c, sink) or
40+
// `DataFlowPrivate::readStep` has already been included in
41+
// `localAdditionalTaintStep`.
4142
DataFlowPrivate::storeStep(src, c, sink) or
4243
FlowSummaryImpl::Private::Steps::summaryGetterStep(src, c, sink, _) or
4344
FlowSummaryImpl::Private::Steps::summarySetterStep(src, c, sink, _)
@@ -112,7 +113,7 @@ predicate localAdditionalTaintStep(DataFlow::Node pred, DataFlow::Node succ, str
112113
or
113114
sliceStep(pred, succ)
114115
or
115-
// Treat container flow as taint for the local taint flow relation
116+
// Treat container read steps as taint for global taint flow.
116117
exists(DataFlow::Content c | DataFlowPrivate::containerContent(c) |
117118
DataFlowPrivate::readStep(pred, c, succ)
118119
)

0 commit comments

Comments
 (0)