JS: Add test for underlying types

Author: asgerf

javascript/ql/test/library-tests/UnderlyingTypes/calls.ts

@@ -0,0 +1,32 @@
+import * as express from 'express';
+
+function getRequest(): express.Request { }
+
+function t1() {
+    getRequest(); // $ hasUnderlyingType='express'.Request
+}
+
+declare function getRequestAmbient(): express.Request;
+
+function t2() {
+    getRequestAmbient(); // $ MISSING: hasUnderlyingType='express'.Request
+}
+
+class C {
+    method(): express.Request { }
+}
+
+function t3(c: C) {
+    c.method(); // $ hasUnderlyingType='express'.Request
+    new C().method(); // $ hasUnderlyingType='express'.Request
+}
+
+function callback(fn: (req: express.Request) => void) { // $ SPURIOUS: hasUnderlyingType='express'.Request - req seems to be a SourceNode
+}
+
+function t4() {
+    callback(function (
+        req // $ hasUnderlyingType='express'.Request
+    ) { }
+    );
+}

javascript/ql/test/library-tests/UnderlyingTypes/expressBulkExport.ts

@@ -0,0 +1 @@
+export * from 'express';

javascript/ql/test/library-tests/UnderlyingTypes/expressBulkExport.use.ts

@@ -0,0 +1,7 @@
+import { Request, Response } from './expressBulkExport';
+
+function t1(req: Request) { // $ hasUnderlyingType='express'.Request
+}
+
+function t2(res: Response) { // $ hasUnderlyingType='express'.Response
+}

javascript/ql/test/library-tests/UnderlyingTypes/expressExportAssign.ts

@@ -0,0 +1,2 @@
+import E = require('express');
+export = E;

javascript/ql/test/library-tests/UnderlyingTypes/expressExportAssign.use.ts

@@ -0,0 +1,4 @@
+import { Request } from "./expressExportAssign";
+
+function t1(req: Request) { // $ hasUnderlyingType='express'.Request
+}

javascript/ql/test/library-tests/UnderlyingTypes/expressExportAssignWrapper.ts

@@ -0,0 +1,5 @@
+import Express = require('express');
+namespace Wrapper {
+    export import E = Express;
+}
+export = Wrapper;

javascript/ql/test/library-tests/UnderlyingTypes/expressExportAssignWrapper.use.ts

@@ -0,0 +1,4 @@
+import { E } from "./expressExportAssignWrapper";
+
+function t1(req: E.Request) { // $ hasUnderlyingType='express'.Request
+}

javascript/ql/test/library-tests/UnderlyingTypes/expressSelectiveExport.ts

@@ -0,0 +1,2 @@
+export { Request } from 'express';
+export { Response as R } from 'express';

javascript/ql/test/library-tests/UnderlyingTypes/expressSelectiveExport.use.ts

@@ -0,0 +1,10 @@
+import { Request, Response, R } from './expressSelectiveExport';
+
+function t1(req: Request) { // $ hasUnderlyingType='express'.Request
+}
+
+function t2(res: Response) { // none, not exported
+}
+
+function t3(res: R) { // $ hasUnderlyingType='express'.Response
+}

javascript/ql/test/library-tests/UnderlyingTypes/expressWrapperExport.ts

@@ -0,0 +1 @@
+export * as wrapper from 'express';

javascript/ql/test/library-tests/UnderlyingTypes/expressWrapperExport.use.ts

@@ -0,0 +1,29 @@
+import { Request, Response, wrapper } from './expressWrapperExport';
+import * as w from './expressWrapperExport';
+
+function t1(req: Request) { // none
+}
+
+function t2(res: Response) { // none
+}
+
+function t3(req: wrapper.Request) { // $ hasUnderlyingType='express'.Request
+}
+
+function t4(res: wrapper.Response) { // $ hasUnderlyingType='express'.Response
+}
+
+function t5(req: w.wrapper.Request) { // $ hasUnderlyingType='express'.Request
+}
+
+function t6(res: w.wrapper.Response) { // $ hasUnderlyingType='express'.Response
+}
+
+function t7(req: w.Request) { // none
+}
+
+function t8(res: w.Response) { // none
+}
+
+function t9(e: typeof w.wrapper) { // $ hasUnderlyingType='express'
+}

javascript/ql/test/library-tests/UnderlyingTypes/jsdoc.js

@@ -0,0 +1,14 @@
+import * as e from 'express';
+import { Response } from 'express';
+
+/**
+ * @param {e.Request} req
+ */
+function t1(req) { // $ hasUnderlyingType='express'.Request SPURIOUS: hasUnderlyingType=e.Request
+}
+
+/**
+ * @param {Response} res
+ */
+function t2(res) { // $ hasUnderlyingType='express'.Response SPURIOUS: hasUnderlyingType=Response
+}

javascript/ql/test/library-tests/UnderlyingTypes/namedImport.ts

@@ -0,0 +1,4 @@
+import { Request } from 'express';
+
+function t1(req: Request) { // $ hasUnderlyingType='express'.Request
+}

javascript/ql/test/library-tests/UnderlyingTypes/namespaceDecls.ts

@@ -0,0 +1,27 @@
+import Express = require('express');
+
+namespace A {
+    export import E = Express;
+}
+namespace B {
+    export import Q = A
+}
+namespace C {
+    import E = Express;
+    export const A = E;
+}
+
+function t1(x: A.E.Request) { // $ hasUnderlyingType='express'.Request
+}
+
+function t2(x: B.Q.E.Request) { // $ hasUnderlyingType='express'.Request
+}
+
+function t3(x: typeof Express) { // $ hasUnderlyingType='express'
+}
+
+function t4(x: typeof A.E) { // $ hasUnderlyingType='express'
+}
+
+function t5(x: typeof C.A) { // $ hasUnderlyingType='express'
+}

javascript/ql/test/library-tests/UnderlyingTypes/namespaceImport.ts

@@ -0,0 +1,15 @@
+import * as express from 'express';
+
+function t1(e: typeof express) { // $ hasUnderlyingType='express'
+}
+
+function t2(req: express.Request) { // $ hasUnderlyingType='express'.Request
+}
+
+function t3(req: Request) { // none, not in scope
+}
+
+type E = typeof express;
+
+function t4(e: E) { // $ hasUnderlyingType='express'
+}

javascript/ql/test/library-tests/UnderlyingTypes/props.ts

@@ -0,0 +1,16 @@
+import * as express from 'express';
+
+interface Foo {
+    req: express.Request;
+    e: typeof express;
+}
+
+function t1(f: Foo) {
+    f.req; // $ hasUnderlyingType='express'.Request
+    f.e; // $ hasUnderlyingType='express'
+
+    const {
+        req, // $ hasUnderlyingType='express'.Request
+        e // $ hasUnderlyingType='express'
+    } = f;
+}

javascript/ql/test/library-tests/UnderlyingTypes/subtype.ts

@@ -0,0 +1,20 @@
+import * as express from 'express';
+
+interface MyRequest extends express.Request {
+
+}
+
+function t1(req: MyRequest) { // $ hasUnderlyingType='express'.Request
+}
+
+class MyRequestClass extends express.Request {
+}
+
+function t2(req: MyRequestClass) { // $ hasUnderlyingType='express'.Request
+}
+
+class MyRequestClass2 implements express.Request {
+}
+
+function t3(req: MyRequestClass2) { // $ hasUnderlyingType='express'.Request
+}

javascript/ql/test/library-tests/UnderlyingTypes/test.expected

@@ -0,0 +1,26 @@
+import javascript
+private import utils.test.InlineExpectationsTest
+
+bindingset[x, y]
+private string join(string x, string y) {
+  if x = "" or y = "" then result = x + y else result = x + "." + y
+}
+
+module TestConfig implements TestSig {
+  string getARelevantTag() { result = "hasUnderlyingType" }
+
+  predicate hasActualResult(Location location, string element, string tag, string value) {
+    element = "" and
+    tag = "hasUnderlyingType" and
+    exists(DataFlow::SourceNode sn | location = sn.getLocation() |
+      sn.hasUnderlyingType(value)
+      or
+      exists(string mod, string name |
+        sn.hasUnderlyingType(mod, name) and
+        value = join("'" + mod + "'", name)
+      )
+    )
+  }
+}
+
+import MakeTest<TestConfig>

javascript/ql/test/library-tests/UnderlyingTypes/test.ql

@@ -0,0 +1,3 @@
+{
+    "include": ["."]
+}