Skip to content

False positive for go/incomplete-hostname-regexp and \Q #15894

Open
@AlekSi

Description

@AlekSi

Description of the false positive

var todoRE = regexp.MustCompile(`^// TODO (\Qhttps://github.com/FerretDB/\E([-\w]+)/issues/(\d+))$`)

That line is annotated with: "This regular expression has an unescaped dot before 'com', so it might match more hosts than expected when the regular expression is used."

What it misses is \Q...\E escape syntax.

Code samples or links to source code

https://github.com/FerretDB/FerretDB/blob/ea9c5bda8f3f80a9263e006995d4257084a600a5/tools/checkcomments/checkcomments.go#L32

URL to the alert on GitHub code scanning (optional)

https://github.com/FerretDB/FerretDB/security/code-scanning/9

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions