-
Notifications
You must be signed in to change notification settings - Fork 1.7k
HTTPS links in documentation #5965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think some of these changes could be valuable. Before any of us starts reviewing in detail, I'd like to check with you, @himanshu007-creator, whether you're prepared to rework the PR in response to review comments about removing unrelated changes or changes to files that should remain static. |
Yes, I can am able to rework on this PR |
This PR touches 15000 lines, across 1200 files. Which is too much to review manually. Could you perhaps explain how you selected the files to change, and what you changed in them? I suppose you used some kind of script. By the way, a quick look at the diff reveals the following example changes that does not match the PR description "HTTPS links in documentation":
|
Yeah, i just searched for all instances of |
As seen above, that approach is not precise enough. Do you want to refine your replacement strategy? |
Yes, I will make the changes as suggested and improve this PR. |
Just to make it clear: the three undesired changes that I listed above is not an exhaustive list. |
Closing the PR due to inactivity, but feel free to reopen if you wish to continue work on it. You need to rerun the script in any case to get past the conflicts. |
Resolved #5163