Skip to content

Commit 7454bb0

Browse files
wxiaoguangwxiaoguang
committed
fix
1 parent 04fab18 commit 7454bb0

File tree

16 files changed

+31
-31
lines changed

16 files changed

+31
-31
lines changed

‎modules/templates/util_avatar.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ func AvatarHTML(src string, size int, class, name string) template.HTML {
3535
}
3636

3737
// use empty alt, otherwise if the image fails to load, the width will follow the "alt" text's width
38-
return template.HTML(`<img loading="lazy" alt="" class="` + class + `" src="` + src + `" title="` + html.EscapeString(name) + `" width="` + sizeStr + `" height="` + sizeStr + `"/>`)
38+
return template.HTML(`<img loading="lazy" alt class="` + class + `" src="` + src + `" title="` + html.EscapeString(name) + `" width="` + sizeStr + `" height="` + sizeStr + `"/>`)
3939
}
4040

4141
// Avatar renders user avatars. args: user, size (int), class (string)

‎templates/install.tmpl

-1
Original file line numberDiff line numberDiff line change
@@ -351,5 +351,4 @@
351351
</div>
352352
</div>
353353
</div>
354-
<img class="tw-hidden" src="{{AssetUrlPrefix}}/img/loading.png">
355354
{{template "base/footer" .}}

‎templates/post-install.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<div role="main" aria-label="{{.Title}}" class="page-content install post-install tw-h-full">
33
<div class="home tw-text-center tw-h-full tw-flex tw-flex-col tw-justify-center"><!-- the "home" class makes the links green -->
44
<!-- the "cup" has a handler, so move it a little leftward to make it visually in the center -->
5-
<div class="tw-ml-[-30px]"><img width="160" src="{{AssetUrlPrefix}}/img/loading.png" alt="" aria-hidden="true"></div>
5+
<div class="tw-ml-[-30px]"><img width="160" src="{{AssetUrlPrefix}}/img/loading.png" alt aria-hidden="true"></div>
66
<div class="tw-my-[2em] tw-text-[18px]">
77
<a id="goto-user-login" href="{{AppSubUrl}}/user/login">{{ctx.Locale.Tr "install.installing_desc"}}</a>
88
</div>

‎templates/repo/diff/image_diff.tmpl

+6-6
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
{{if .blobBase}}
2323
<span class="side">
2424
<p class="side-header">{{ctx.Locale.Tr "repo.diff.file_before"}}</p>
25-
<span class="before-container"><img class="image-before"></span>
25+
<span class="before-container"><img alt class="image-before"></span>
2626
<p>
2727
<span class="bounds-info-before">
2828
{{ctx.Locale.Tr "repo.diff.file_image_width"}}: <span class="text bounds-info-width"></span>
@@ -37,7 +37,7 @@
3737
{{if .blobHead}}
3838
<span class="side">
3939
<p class="side-header">{{ctx.Locale.Tr "repo.diff.file_after"}}</p>
40-
<span class="after-container"><img class="image-after"></span>
40+
<span class="after-container"><img alt class="image-after"></span>
4141
<p>
4242
<span class="bounds-info-after">
4343
{{ctx.Locale.Tr "repo.diff.file_image_width"}}: <span class="text bounds-info-width"></span>
@@ -55,9 +55,9 @@
5555
<div class="ui bottom attached tab image-diff-container" data-tab="diff-swipe-{{.file.NameHash}}">
5656
<div class="diff-swipe">
5757
<div class="swipe-frame">
58-
<span class="before-container"><img class="image-before"></span>
58+
<span class="before-container"><img alt class="image-before"></span>
5959
<span class="swipe-container">
60-
<span class="after-container"><img class="image-after"></span>
60+
<span class="after-container"><img alt class="image-after"></span>
6161
</span>
6262
<span class="swipe-bar">
6363
<span class="handle top-handle"></span>
@@ -70,8 +70,8 @@
7070
<div class="diff-overlay">
7171
<input type="range" min="0" max="100" value="50">
7272
<div class="overlay-frame">
73-
<span class="before-container"><img class="image-before"></span>
74-
<span class="after-container"><img class="image-after"></span>
73+
<span class="before-container"><img alt class="image-before"></span>
74+
<span class="after-container"><img alt class="image-after"></span>
7575
</div>
7676
</div>
7777
</div>

‎templates/repo/icon.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{{$avatarLink := (.RelAvatarLink ctx)}}
22
{{if $avatarLink}}
3-
<img class="ui avatar tw-align-middle" src="{{$avatarLink}}" width="24" height="24" alt="" aria-hidden="true">
3+
<img class="ui avatar tw-align-middle" src="{{$avatarLink}}" width="24" height="24" alt aria-hidden="true">
44
{{else if $.IsMirror}}
55
{{svg "octicon-mirror" 24}}
66
{{else if $.IsFork}}

‎templates/repo/issue/labels/label_edit_modal.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
<div class="field">
5151
<label for="color">{{ctx.Locale.Tr "repo.issues.label_color"}}</label>
5252
<div class="column js-color-picker-input">
53-
<input name="color" value="#70c24a"placeholder="#c320f6" required maxlength="7">
53+
<input name="color" value="#70c24a" placeholder="#c320f6" required maxlength="7">
5454
{{template "repo/issue/label_precolors"}}
5555
</div>
5656
</div>

‎templates/repo/issue/milestone_issues.tmpl

+3-3
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@
2828
{{end}}
2929
<div class="tw-flex tw-flex-col tw-gap-2">
3030
<progress class="milestone-progress-big" value="{{.Milestone.Completeness}}" max="100"></progress>
31-
<div class="tw-flex tw-gap-4">
32-
<div classs="tw-flex tw-items-center">
31+
<div class="flex-text-block tw-gap-4">
32+
<div class="flex-text-inline">
3333
{{$closedDate:= DateUtils.TimeSince .Milestone.ClosedDateUnix}}
3434
{{if .IsClosed}}
3535
{{svg "octicon-clock"}} {{ctx.Locale.Tr "repo.milestones.closed" $closedDate}}
@@ -46,7 +46,7 @@
4646
{{end}}
4747
{{end}}
4848
</div>
49-
<div class="tw-mr-2">{{ctx.Locale.Tr "repo.milestones.completeness" .Milestone.Completeness}}</div>
49+
<div>{{ctx.Locale.Tr "repo.milestones.completeness" .Milestone.Completeness}}</div>
5050
{{if .TotalTrackedTime}}
5151
<div data-tooltip-content='{{ctx.Locale.Tr "tracked_time_summary"}}'>
5252
{{svg "octicon-clock"}}

‎templates/repo/issue/view_content/comments.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -615,7 +615,7 @@
615615
<div class="timeline-item-group">
616616
<div class="timeline-item event" id="{{.HashTag}}">
617617
<a class="timeline-avatar"{{if gt .Poster.ID 0}} href="{{.Poster.HomeLink}}"{{end}}>
618-
<img src="{{.Poster.AvatarLink ctx}}" width="40" height="40">
618+
<img alt src="{{.Poster.AvatarLink ctx}}" width="40" height="40">
619619
</a>
620620
<span class="badge grey">{{svg "octicon-x" 16}}</span>
621621
<span class="text grey muted-links">

‎templates/repo/migrate/migrating.tmpl

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@
99
<div class="ui stackable middle very relaxed page grid">
1010
<div id="repo_migrating" class="sixteen wide tw-text-center centered column" data-migrating-repo-link="{{.Link}}">
1111
<div>
12-
<img src="{{AssetUrlPrefix}}/img/loading.png">
12+
<img alt src="{{AssetUrlPrefix}}/img/loading.png">
1313
</div>
1414
</div>
1515
<div id="repo_migrating_failed_image" class="sixteen wide tw-text-center centered column tw-hidden">
1616
<div>
17-
<img src="{{AssetUrlPrefix}}/img/failed.png">
17+
<img alt src="{{AssetUrlPrefix}}/img/failed.png">
1818
</div>
1919
</div>
2020
</div>

‎templates/repo/settings/lfs_file.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
{{else if not .IsTextFile}}
2222
<div class="view-raw">
2323
{{if .IsImageFile}}
24-
<img src="{{$.RawFileLink}}">
24+
<img alt="{{$.RawFileLink}}" src="{{$.RawFileLink}}">
2525
{{else if .IsVideoFile}}
2626
<video controls src="{{$.RawFileLink}}">
2727
<strong>{{ctx.Locale.Tr "repo.video_not_supported_in_browser"}}</strong>

‎templates/repo/view_file.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@
9898
{{else if not .IsTextSource}}
9999
<div class="view-raw">
100100
{{if .IsImageFile}}
101-
<img src="{{$.RawFileLink}}">
101+
<img alt="{{$.RawFileLink}}" src="{{$.RawFileLink}}">
102102
{{else if .IsVideoFile}}
103103
<video controls src="{{$.RawFileLink}}">
104104
<strong>{{ctx.Locale.Tr "repo.video_not_supported_in_browser"}}</strong>

‎templates/shared/webhook/icon.tmpl

+8-8
Original file line numberDiff line numberDiff line change
@@ -5,23 +5,23 @@
55
{{if eq .HookType "gitea"}}
66
{{svg "gitea-gitea" $size "img"}}
77
{{else if eq .HookType "gogs"}}
8-
<img width="{{$size}}" height="{{$size}}" src="{{AssetUrlPrefix}}/img/gogs.ico">
8+
<img alt width="{{$size}}" height="{{$size}}" src="{{AssetUrlPrefix}}/img/gogs.ico">
99
{{else if eq .HookType "slack"}}
10-
<img width="{{$size}}" height="{{$size}}" src="{{AssetUrlPrefix}}/img/slack.png">
10+
<img alt width="{{$size}}" height="{{$size}}" src="{{AssetUrlPrefix}}/img/slack.png">
1111
{{else if eq .HookType "discord"}}
12-
<img width="{{$size}}" height="{{$size}}" src="{{AssetUrlPrefix}}/img/discord.png">
12+
<img alt width="{{$size}}" height="{{$size}}" src="{{AssetUrlPrefix}}/img/discord.png">
1313
{{else if eq .HookType "dingtalk"}}
14-
<img width="{{$size}}" height="{{$size}}" src="{{AssetUrlPrefix}}/img/dingtalk.ico">
14+
<img alt width="{{$size}}" height="{{$size}}" src="{{AssetUrlPrefix}}/img/dingtalk.ico">
1515
{{else if eq .HookType "telegram"}}
16-
<img width="{{$size}}" height="{{$size}}" src="{{AssetUrlPrefix}}/img/telegram.png">
16+
<img alt width="{{$size}}" height="{{$size}}" src="{{AssetUrlPrefix}}/img/telegram.png">
1717
{{else if eq .HookType "msteams"}}
18-
<img width="{{$size}}" height="{{$size}}" src="{{AssetUrlPrefix}}/img/msteams.png">
18+
<img alt width="{{$size}}" height="{{$size}}" src="{{AssetUrlPrefix}}/img/msteams.png">
1919
{{else if eq .HookType "feishu"}}
2020
{{svg "gitea-feishu" $size "img"}}
2121
{{else if eq .HookType "matrix"}}
2222
{{svg "gitea-matrix" $size "img"}}
2323
{{else if eq .HookType "wechatwork"}}
24-
<img width="{{$size}}" height="{{$size}}" src="{{AssetUrlPrefix}}/img/wechatwork.png">
24+
<img alt width="{{$size}}" height="{{$size}}" src="{{AssetUrlPrefix}}/img/wechatwork.png">
2525
{{else if eq .HookType "packagist"}}
26-
<img width="{{$size}}" height="{{$size}}" src="{{AssetUrlPrefix}}/img/packagist.png">
26+
<img alt width="{{$size}}" height="{{$size}}" src="{{AssetUrlPrefix}}/img/packagist.png">
2727
{{end}}

‎templates/user/dashboard/feeds.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@
9191
{{range $push.Commits}}
9292
{{$commitLink := printf "%s/commit/%s" $repoLink .Sha1}}
9393
<div class="flex-text-block">
94-
<img class="ui avatar" src="{{$push.AvatarLink ctx .AuthorEmail}}" title="{{.AuthorName}}" width="16" height="16">
94+
<img alt class="ui avatar" src="{{$push.AvatarLink ctx .AuthorEmail}}" title="{{.AuthorName}}" width="16" height="16">
9595
<a class="ui sha label" href="{{$commitLink}}">{{ShortSha .Sha1}}</a>
9696
<span class="text truncate">
9797
{{ctx.RenderUtils.RenderCommitMessage .Message ($repo.ComposeCommentMetas ctx)}}

‎web_src/css/base.css

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
/* fonts */
33
--fonts-proportional: -apple-system, "Segoe UI", system-ui, Roboto, "Helvetica Neue", Arial;
44
--fonts-monospace: ui-monospace, SFMono-Regular, "SF Mono", Menlo, Monaco, Consolas, "Liberation Mono", "Courier New", monospace, var(--fonts-emoji);
5-
--fonts-emoji: "Apple Color Emoji", "Segoe UI Emoji", "Noto Color Emoji", "Twemoji Mozilla";
5+
/* "Twemoji Mozilla" emoji font is widely used by browsers like Firefox, Pale Moon, and it is more likely up-to-dated than the system emoji font */
6+
--fonts-emoji: "Twemoji Mozilla", "Apple Color Emoji", "Segoe UI Emoji", "Noto Color Emoji";
67
/* font weights - use between 400 and 600 for general purposes. Avoid 700 as it is perceived too bold */
78
--font-weight-light: 300;
89
--font-weight-normal: 400;

‎web_src/js/features/repo-issue-list.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ function initDropdownUserRemoteSearch(el: Element) {
138138
// the content is provided by backend IssuePosters handler
139139
processedResults.length = 0;
140140
for (const item of resp.results) {
141-
let html = `<img class="ui avatar tw-align-middle" src="${htmlEscape(item.avatar_link)}" aria-hidden="true" alt="" width="20" height="20"><span class="gt-ellipsis">${htmlEscape(item.username)}</span>`;
141+
let html = `<img class="ui avatar tw-align-middle" src="${htmlEscape(item.avatar_link)}" aria-hidden="true" alt width="20" height="20"><span class="gt-ellipsis">${htmlEscape(item.username)}</span>`;
142142
if (item.full_name) html += `<span class="search-fullname tw-ml-2">${htmlEscape(item.full_name)}</span>`;
143143
if (selectedUsername.toLowerCase() === item.username.toLowerCase()) selectedUsername = item.username;
144144
processedResults.push({value: item.username, name: html});

‎web_src/js/features/tribute.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export async function attachTribute(element: HTMLElement) {
3434
menuItemTemplate: (item: TributeItem) => {
3535
return `
3636
<div class="tribute-item">
37-
<img src="${htmlEscape(item.original.avatar)}" width="21" height="21"/>
37+
<img alt src="${htmlEscape(item.original.avatar)}" width="21" height="21"/>
3838
<span class="name">${htmlEscape(item.original.name)}</span>
3939
${item.original.fullname && item.original.fullname !== '' ? `<span class="fullname">${htmlEscape(item.original.fullname)}</span>` : ''}
4040
</div>

0 commit comments

Comments
 (0)