V2: Query API incompatibility around missing time windows

[simonswine]

Describe the bug

A clear and concise description of what the bug is.

When using the v2 mode, the API behaves directly, it seems to treat the time window as required:

$ curl -H "content-type: application/json"  -d '{"label_names":["__profile_type__"]}' "http://v1/querier.v1.QuerierService/Series"
{"labelsSet":[{"labels":[...]}]}

$ curl -H "content-type: application/json"  -d '{"label_names":["__profile_type__"]}' "http://v2/querier.v1.QuerierService/Series"
{"code":"invalid_argument","message":"missing time range in the query"}%

Expected behavior

Follow the same API behaviour, with and without v2

[kolesnikovae]

Good catch! This was intentional: I consider queries without the time range invalid, and I'd like to avoid bug-to-bug compatibility. Please clarify if there's a known case where we do rely on this behaviour.

[simonswine]

I guess I am not aware of any frontend/cli tool from us relying on it.

But my curl history, is using that a lot as it is easier than working out the timestamps.

We should update this:

pyroscope/api/querier/v1/querier.proto

Lines 50 to 51 in 28e1d6c

	// Milliseconds since epoch. If missing or zero, only the ingesters will be
	// queried.

At worst, if it turns out someone is relying on this we can reinstate a form of old behaviour.