Skip to content

Commit 5a6745b

Browse files
committed
opentelemetry: Missing locality should be empty string
From gRFC A78: > If no locality information is available, the label will be set to the > empty string.
1 parent 45a91bd commit 5a6745b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

opentelemetry/src/main/java/io/grpc/opentelemetry/OpenTelemetryMetricsModule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ void recordFinishedAttempt() {
213213
if (module.localityEnabled) {
214214
String savedLocality = locality;
215215
if (savedLocality == null) {
216-
savedLocality = "unknown";
216+
savedLocality = "";
217217
}
218218
builder.put(LOCALITY_KEY, savedLocality);
219219
}

opentelemetry/src/test/java/io/grpc/opentelemetry/OpenTelemetryMetricsModuleTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -974,7 +974,7 @@ public void clientLocalityMetrics_missing() {
974974

975975
io.opentelemetry.api.common.Attributes clientAttributesWithLocality
976976
= clientAttributes.toBuilder()
977-
.put(LOCALITY_KEY, "unknown")
977+
.put(LOCALITY_KEY, "")
978978
.build();
979979

980980
assertThat(openTelemetryTesting.getMetrics())

0 commit comments

Comments
 (0)