Skip to content

Remove RetriableStream flush workaround #9768

Open
@ejona86

Description

@ejona86

In #9360 I added this workaround:

// TODO(ejona): Workaround Netty memory leak. Message writes always need to be followed by
// flushes (or half close), but retry appears to have a code path that the flushes may
// not happen. The code needs to be fixed and this removed. See #9340.
substream.stream.flush();

A flush() must always follow a write (but other flushes and calls could be in-between). I tried to flush everywhere but it didn't work at the time. See also #9340. It is possible there were interactions with #9547 which prevented it from working and just trying again may work.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions