Description
There are a few disqualification criteria based on users that can be specified in the first round creation: based on juror (dq_by_uploader), coordinator (dq_coords), maintainers (dq_maintainers) and of organizers (dq_organizers). It looks like these choices are not implemented as expected.
As context: I created on beta a first round and was unable to select disqualification based on juror (the option is not available), which is in line with it missing from fileSettingsOptions in RoundNew.vue. I don't know if this was intentionally left out - but disqualifying jurors seems a common desirable feature so it might be nice to bring back. Did we perhaps decide it should always be active? This would be confusing because the default settings for a round have 'dq_by_uploader': False. I might miss something here.
When I set dq_coords to True in a new round, where I am the coordinator, and select a category with a photo of mine (or give a list for which I uploaded an image) the image that I uploaded, is still added to the round. I am still able to vote for it, and it still ends up in the results.
It looks like the disqualification of coordinators happens also in autodisqualify_by_uploader in rdb.py. And this only gets called if dq_by_uploader is True. My suspicion is that setting dq_by_uploader by default to True would accomplish both disqualifying jurors by default, and re-activating the other disqualification criteria.
What is also seems possible, is to add a checkbox for juror in the config, set dq_by_uploader to True if any of the roles should lead to disqualification, and add an if-statement in the autodisqualify function. But there may be interactions I didn't account for (e.g. there seems to be an active disqualifying action provided for, that I can't find).
Reproduce:
- Go to https://montage-beta.toolforge.org/#/campaign/8-test-campaign-for-dq-coords
- Add yourself as coordinator
- Delete round
- Add new round and select a category with your upload in it. E.g. "Reliefs of Galba"
- Ensure that 'disqualify coordinators' is selected
- Create round
- Observe that your image is still there (e.g. "0000.999.71330.obv.noscale.jpg")
