Skip to content

Commit 7f8bd13

Browse files
committed
Drop end tag tree walker's data (always empty now)
1 parent dc879ff commit 7f8bd13

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

html5lib/tests/test_treewalkers.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -78,15 +78,15 @@ def test_all_tokens(self):
7878
expected = [
7979
{'data': {}, 'type': 'StartTag', 'namespace': 'http://www.w3.org/1999/xhtml', 'name': 'html'},
8080
{'data': {}, 'type': 'StartTag', 'namespace': 'http://www.w3.org/1999/xhtml', 'name': 'head'},
81-
{'data': {}, 'type': 'EndTag', 'namespace': 'http://www.w3.org/1999/xhtml', 'name': 'head'},
81+
{'type': 'EndTag', 'namespace': 'http://www.w3.org/1999/xhtml', 'name': 'head'},
8282
{'data': {}, 'type': 'StartTag', 'namespace': 'http://www.w3.org/1999/xhtml', 'name': 'body'},
8383
{'data': 'a', 'type': 'Characters'},
8484
{'data': {}, 'type': 'StartTag', 'namespace': 'http://www.w3.org/1999/xhtml', 'name': 'div'},
8585
{'data': 'b', 'type': 'Characters'},
86-
{'data': {}, 'type': 'EndTag', 'namespace': 'http://www.w3.org/1999/xhtml', 'name': 'div'},
86+
{'type': 'EndTag', 'namespace': 'http://www.w3.org/1999/xhtml', 'name': 'div'},
8787
{'data': 'c', 'type': 'Characters'},
88-
{'data': {}, 'type': 'EndTag', 'namespace': 'http://www.w3.org/1999/xhtml', 'name': 'body'},
89-
{'data': {}, 'type': 'EndTag', 'namespace': 'http://www.w3.org/1999/xhtml', 'name': 'html'}
88+
{'type': 'EndTag', 'namespace': 'http://www.w3.org/1999/xhtml', 'name': 'body'},
89+
{'type': 'EndTag', 'namespace': 'http://www.w3.org/1999/xhtml', 'name': 'html'}
9090
]
9191
for treeName, treeCls in sorted(treeTypes.items()):
9292
p = html5parser.HTMLParser(tree=treeCls["builder"])

html5lib/treewalkers/_base.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@ def startTag(self, namespace, name, attrs):
4343
def endTag(self, namespace, name):
4444
return {"type": "EndTag",
4545
"name": name,
46-
"namespace": namespace,
47-
"data": {}}
46+
"namespace": namespace}
4847

4948
def text(self, data):
5049
data = data

0 commit comments

Comments
 (0)