Skip to content

Commit f725af6

Browse files
authored
Merge pull request #15 from WTW-IM/render-escape
Update: ensuring we don't mount when not connected
2 parents 7d35c38 + 34cbd21 commit f725af6

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

src/ReactHTMLElement.ts

+4-5
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,10 @@ class ReactHTMLElement extends HTMLElement {
3535
this._mountPoint = mount;
3636
}
3737

38-
render(
39-
app: Parameters<ReactDOM.Renderer>[0][number]
40-
): ReturnType<ReactDOM.Renderer> {
41-
// eslint-disable-next-line react/no-render-return-value
42-
return ReactDOM.render(app, this.mountPoint);
38+
render(app: Parameters<ReactDOM.Renderer>[0][number]): void {
39+
if (!this.isConnected) return;
40+
41+
ReactDOM.render(app, this.mountPoint);
4342
}
4443

4544
disconnectedCallback(): void {

0 commit comments

Comments
 (0)