Skip to content

fix: TestPackageListParser/test_valid_requirements is broken #3644

Open
@terriko

Description

@terriko

Description

The test "test_valid_requirements" in test/test_package_list_parser.py is broken and needs to be updated or replaced with a correct test that covers the same code.

This may have been broken for some time, as an unrelated issue caused the test to not be run at all (see #3631). It's possible that the issue is not in the test code but elsewhere. It's possible that it's just an ordering thing in the array of test data -- you may want to consider replacing the current assert with an assert for each product to help you narrow down the problem.

Note that this is currently set to run only on ubuntu systems. although it's part of something that is ubuntu-specific, this particular piece looks like it could be debugged on any system as long as you remove the skipif section above it.

To reproduce

Run just this test:
pytest -k test_valid_requirements

(If it is showing up as skipped, you will need to enable it in the code yourself.)

Expected case: the test should pass
Actual case: the test fails due to differences in the expected and actual output arrays of product info.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingtests

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions