Skip to content

Commit d9987da

Browse files
authored
fix(auth, ios): deprecate MultifactorInfo.enrollmentDate should be enrollmentTime (#7653)
rename `enrollmentDate` -> `enrollmentTime` on iOS to match Android/Web (ref: https://firebase.google.com/docs/reference/js/auth.multifactorinfo) keep `enrollmentDate` around on ios for backwards compatibility, mark as deprecated. ref: - https://github.com/invertase/react-native-firebase/blob/main/packages/auth/android/src/main/java/io/invertase/firebase/auth/ReactNativeFirebaseAuthModule.java#L2500 - https://github.com/invertase/react-native-firebase/blob/main/packages/auth/lib/index.d.ts#L483 split from #7565
1 parent 1ae7481 commit d9987da

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

packages/auth/ios/RNFBAuth/RNFBAuthModule.m

+5-3
Original file line numberDiff line numberDiff line change
@@ -1686,13 +1686,15 @@ - (NSDictionary *)firebaseUserToDict:(FIRUser *)user {
16861686
NSMutableArray *enrolledFactors = [NSMutableArray array];
16871687

16881688
for (FIRPhoneMultiFactorInfo *hint in hints) {
1689-
NSString *enrollmentDate =
1689+
NSString *enrollmentTime =
16901690
[[[NSISO8601DateFormatter alloc] init] stringFromDate:hint.enrollmentDate];
16911691
[enrolledFactors addObject:@{
16921692
@"uid" : hint.UID,
16931693
@"factorId" : [self getJSFactorId:(hint.factorID)],
16941694
@"displayName" : hint.displayName == nil ? [NSNull null] : hint.displayName,
1695-
@"enrollmentDate" : enrollmentDate,
1695+
@"enrollmentTime" : enrollmentTime,
1696+
// @deprecated enrollmentDate kept for backwards compatibility, please use enrollmentTime
1697+
@"enrollmentDate" : enrollmentTime,
16961698
}];
16971699
}
16981700
return enrolledFactors;
@@ -1745,4 +1747,4 @@ - (FIRActionCodeSettings *)buildActionCodeSettings:(NSDictionary *)actionCodeSet
17451747
return settings;
17461748
}
17471749

1748-
@end
1750+
@end

0 commit comments

Comments
 (0)