Skip to content

Commit e5ffaf1

Browse files
committed
Issue#353 (crypto): Update checkstyle to work again and move files.
They previously lived under org.jcryptool.releng which stands for release engineering - IMHO not the right directory as it has nothing to do with releases. I would opt for a hidden directory as with other project-but-not-code related stuff.
1 parent aabd16c commit e5ffaf1

File tree

4 files changed

+19
-23
lines changed

4 files changed

+19
-23
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
<?xml version="1.0"?>
2+
3+
<!DOCTYPE suppressions PUBLIC
4+
"-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
5+
"https://checkstyle.org/dtds/suppressions_1_2.dtd">
6+
7+
<suppressions>
8+
<suppress checks=".*" files="Messages.java"/>
9+
</suppressions>
10+

org.jcryptool.releng/checkstyle.xml renamed to .development-configs/checkstyle.xml

+9-14
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,18 @@
1-
<?xml version="1.0" encoding="UTF-8"?>
2-
<!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
1+
<?xml version="1.0"?>
2+
<!DOCTYPE module PUBLIC
3+
"-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
4+
"https://checkstyle.org/dtds/configuration_1_3.dtd">
35

4-
<!--
5-
This configuration file was written by the eclipse-cs plugin configuration editor
6-
-->
76
<!--
87
Checkstyle-Configuration: JCrypTool Checkstyle
9-
Description: none
8+
Description: use this checkstyle configuration for JCryptool development
109
-->
1110
<module name="Checker">
1211
<property name="severity" value="warning"/>
1312
<module name="TreeWalker">
1413
<property name="tabWidth" value="4"/>
1514
<module name="JavadocMethod">
1615
<property name="excludeScope" value="private"/>
17-
<property name="suppressLoadErrors" value="true"/>
1816
</module>
1917
<module name="JavadocType"/>
2018
<module name="JavadocVariable">
@@ -37,9 +35,6 @@
3735
<module name="IllegalImport"/>
3836
<module name="RedundantImport"/>
3937
<module name="UnusedImports"/>
40-
<module name="LineLength">
41-
<property name="max" value="120"/>
42-
</module>
4338
<module name="MethodLength">
4439
<property name="max" value="200"/>
4540
</module>
@@ -75,9 +70,6 @@
7570
<module name="InnerAssignment"/>
7671
<module name="MagicNumber"/>
7772
<module name="MissingSwitchDefault"/>
78-
<module name="RedundantThrows">
79-
<property name="suppressLoadErrors" value="true"/>
80-
</module>
8173
<module name="SimplifyBooleanExpression"/>
8274
<module name="SimplifyBooleanReturn"/>
8375
<module name="DesignForExtension">
@@ -108,6 +100,9 @@
108100
<property name="ignoreNumbers" value="-1, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 100, 128, 256, 512, 768, 1024, 2048, 4096"/>
109101
</module>
110102
</module>
103+
<module name="LineLength">
104+
<property name="max" value="120"/>
105+
</module>
111106
<module name="NewlineAtEndOfFile">
112107
<property name="severity" value="ignore"/>
113108
<metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
@@ -122,6 +117,6 @@
122117
<metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
123118
</module>
124119
<module name="SuppressionFilter">
125-
<property name="file" value="checkstyle-suppressions.xml"/>
120+
<property name="file" value="${config_loc}/checkstyle-suppressions.xml"/>
126121
</module>
127122
</module>

org.jcryptool.releng/checkstyle-suppressions.xml

-9
This file was deleted.

0 commit comments

Comments
 (0)