Connect when the server ready

==3059== Memcheck, a memory error detector
==3059== Copyright (C) 2002-2015, and GNU GPL'd, by Julian Seward et al.
==3059== Using Valgrind-3.11.0 and LibVEX; rerun with -h for copyright info
==3059== Command: /root/work_space/iotjs/build/x86_64-linux/debug/bin/iotjs /root/work_space/iotjs/test/run_pass/test_net_8.js
==3059==
AssertionError: {"actual":"1","expected":"12","operator":"=="}
AssertionError: {"actual":1,"expected":0,"operator":"=="}
==3059==
==3059== HEAP SUMMARY:
==3059==     in use at exit: 0 bytes in 0 blocks
==3059==   total heap usage: 131 allocs, 131 frees, 314,345 bytes allocated
==3059==

According to this, the server on close event triggered multiple times by close function

wait all four connection to end

Author: lygstate

Diff for: test/run_pass/test_net_3.js

@@ -19,17 +19,17 @@ var assert = require('assert');
 
 
 var port = 22703;
-var limit = 200;
+var limit = 233;
 var server = net.createServer();
 
-server.listen({ port: port });
+server.listen({ port: port }, startTesting);
 
 server.on('connection', function(socket) {
   var i = 0;
   var writing = function() {
     var ok;
     do {
-      ok = socket.write("" + (i % 10));
+      ok = socket.write('' + (i % 10));
       if (++i == limit) {
         socket.end();
         ok = false;
@@ -40,47 +40,59 @@ server.on('connection', function(socket) {
   writing();
 });
 
-
 var msg1 = '';
-var socket1 = net.createConnection(port);
+var msg2 = '';
+var msg3 = '';
+var msg4 = '';
+var endCount = 0;
+var connectListenerCheck = false;
 
-socket1.on('data', function(data) {
-  msg1 += data;
-});
+function endCallback() {
+  endCount += 1;
+  if (endCount === 4) {
+    server.close();
+  }
+}
 
+function startTesting() {
+  var socket1 = net.createConnection(port);
 
-var msg2 = '';
-var socket2 = net.createConnection({port: port});
+  socket1.on('data', function(data) {
+    msg1 += data;
+  });
+  socket1.on('end', endCallback);
 
-socket2.on('data', function(data) {
-  msg2 += data;
-});
 
+  var socket2 = net.createConnection({port: port});
 
-var msg3 = '';
-var socket3 = net.createConnection({port: port, host: '127.0.0.1'});
+  socket2.on('data', function(data) {
+    msg2 += data;
+  });
+  socket2.on('end', endCallback);
 
-socket3.on('data', function(data) {
-  msg3 += data;
-});
 
+  var socket3 = net.createConnection({port: port, host: '127.0.0.1'});
 
-var msg4 = '';
-var connectListenerCheck = false;
-var socket4 = net.createConnection({port: port}, function() {
-  connectListenerCheck = true;
-});
+  socket3.on('data', function(data) {
+    msg3 += data;
+  });
+  socket3.on('end', endCallback);
 
-socket4.on('data', function(data) {
-  msg4 += data;
-});
 
-socket4.on('end', function() {
-  server.close();
-});
+  var socket4 = net.createConnection({port: port}, function() {
+    connectListenerCheck = true;
+  });
+
+  socket4.on('data', function(data) {
+    msg4 += data;
+  });
 
+  socket4.on('end', endCallback);
+}
 
 process.on('exit', function(code) {
+  assert.equal(code, 0);
+  assert.equal(endCount, 4);
   assert.equal(msg1.length, limit);
   assert.equal(msg2.length, limit);
   assert.equal(msg3.length, limit);

Diff for: test/run_pass/test_net_8.js

@@ -32,7 +32,6 @@ server.on('connection', function(socket) {
     socket.end(data);
   });
   socket.on('close', function() {
-    server.close();
   });
 });
 
@@ -46,6 +45,7 @@ sock2.connect(port, 'localhost');
 
 sock1.on('data', function(data) {
   msg += data;
+  sendSock2Data();
 });
 
 sock1.on('end', function() {
@@ -58,15 +58,16 @@ sock2.on('data', function(data) {
 
 sock2.on('end', function() {
   sock2.end();
+  server.close();
 });
 
 timers.setTimeout(function() {
   sock1.write('1');
 }, 1000);
 
-timers.setTimeout(function() {
+function sendSock2Data() {
   sock2.write('2');
-}, 2000);
+}
 
 process.on('exit', function(code) {
   assert.equal(code, 0);

Diff for: test/run_pass/test_tls_3.js

@@ -24,14 +24,15 @@ var server_message = '';
 var server_closed = false;
 var server_handshake_done = false;
 var handshake_done = false;
+var endCount = 0;
 
 var port = 8080;
 
 var server_options = {
   key: fs.readFileSync(process.cwd() + '/resources/my_key.key').toString(),
   cert: fs.readFileSync(process.cwd() + '/resources/my_crt.crt'),
   rejectUnauthorized: false,
-  isServer: true
+  isServer: true,
 };
 
 var server = tls.createServer(server_options, function(socket) {
@@ -41,7 +42,7 @@ var server = tls.createServer(server_options, function(socket) {
     client_message = data.toString();
   });
 
-}).listen(port, function() {});
+}).listen(port, startTesting);
 
 server.on('secureConnection', function() {
   server_handshake_done = true;
@@ -51,47 +52,57 @@ server.on('close', function() {
   server_closed = true;
 });
 
-var socket1 = tls.connect(port);
+function endCallback() {
+  endCount += 1;
+  if (endCount === 3) {
+    server.close();
+  }
+}
 
-socket1.on('secureConnect', function() {
-  handshake_done = true;
-});
+function startTesting() {
+  var socket1 = tls.connect(port);
 
-socket1.on('data', function(data) {
-  server_message = data.toString();
-  socket1.write('Client hello');
-  socket1.end();
-});
+  socket1.on('secureConnect', function() {
+    handshake_done = true;
+  });
 
-var socket2 = tls.connect(port, 'localhost');
+  socket1.on('data', function(data) {
+    server_message = data.toString();
+    socket1.write('Client hello');
+    socket1.end();
+  });
+  socket1.on('end', endCallback);
 
-socket2.on('secureConnect', function() {
-  handshake_done = true;
-});
+  var socket2 = tls.connect(port, 'localhost');
 
-socket2.on('data', function(data) {
-  server_message = data.toString();
-  socket2.write('Client hello');
-  socket2.end();
-});
+  socket2.on('secureConnect', function() {
+    handshake_done = true;
+  });
 
-var socket3 = tls.connect(port, function() {});
+  socket2.on('data', function(data) {
+    server_message = data.toString();
+    socket2.write('Client hello');
+    socket2.end();
+  });
+  socket2.on('end', endCallback);
 
-socket3.on('secureConnect', function() {
-  handshake_done = true;
-});
+  var socket3 = tls.connect(port, function() {});
 
-socket3.on('data', function(data) {
-  server_message = data.toString();
-  socket3.write('Client hello');
-  socket3.end();
-});
+  socket3.on('secureConnect', function() {
+    handshake_done = true;
+  });
 
-socket3.on('end', function() {
-  server.close();
-});
+  socket3.on('data', function(data) {
+    server_message = data.toString();
+    socket3.write('Client hello');
+    socket3.end();
+  });
+
+  socket3.on('end', endCallback);
+}
 
 process.on('exit', function() {
+  assert.equal(endCount, 3);
   assert.equal(handshake_done, true);
   assert.equal(server_handshake_done, true);
   assert.equal(client_message === expected_client_msg, true);

Diff for: test/run_pass/test_tls_4.js

@@ -24,14 +24,15 @@ var server_message = '';
 var server_closed = false;
 var server_handshake_done = false;
 var handshake_done = false;
+var endCount = 0;
 
 var port = 8080;
 
 var server_options = {
   key: fs.readFileSync(process.cwd() + '/resources/my_key.key').toString(),
   cert: fs.readFileSync(process.cwd() + '/resources/my_crt.crt'),
   rejectUnauthorized: false,
-  isServer: true
+  isServer: true,
 };
 
 var server = tls.createServer(server_options, function(socket) {
@@ -41,7 +42,7 @@ var server = tls.createServer(server_options, function(socket) {
     client_message = data.toString();
   });
 
-}).listen(port, function() { });
+}).listen(port, startTesting);
 
 server.on('secureConnection', function() {
   server_handshake_done = true;
@@ -51,51 +52,61 @@ server.on('close', function() {
   server_closed = true;
 });
 
-var socket_options = {
-   rejectUnauthorized: false,
+function endCallback() {
+  endCount += 1;
+  if (endCount === 3) {
+    server.close();
+  }
 }
 
-var socket1 = tls.connect(port, 'localhost', socket_options);
+function startTesting() {
+  var socket_options = {
+    rejectUnauthorized: false,
+  };
 
-socket1.on('secureConnect', function() {
-  handshake_done = true;
-});
+  var socket1 = tls.connect(port, 'localhost', socket_options);
 
-socket1.on('data', function(data) {
-  server_message = data.toString();
-  socket1.write('Client hello');
-  socket1.end();
-});
+  socket1.on('secureConnect', function() {
+    handshake_done = true;
+  });
 
-var socket2 = tls.connect(port, 'localhost', socket_options, function() {});
+  socket1.on('data', function(data) {
+    server_message = data.toString();
+    socket1.write('Client hello');
+    socket1.end();
+  });
+  socket1.on('end', endCallback);
 
-socket1.on('secureConnect', function() {
-  handshake_done = true;
-});
+  var socket2 = tls.connect(port, 'localhost', socket_options, function() {});
 
-socket2.on('data', function(data) {
-  server_message = data.toString();
-  socket2.write('Client hello');
-  socket2.end();
-});
+  socket1.on('secureConnect', function() {
+    handshake_done = true;
+  });
 
-var socket3 = tls.connect(port, 'localhost', function() {});
+  socket2.on('data', function(data) {
+    server_message = data.toString();
+    socket2.write('Client hello');
+    socket2.end();
+  });
+  socket2.on('end', endCallback);
 
-socket3.on('secureConnect', function(){
-  handshake_done = true;
-});
+  var socket3 = tls.connect(port, 'localhost', function() {});
 
-socket3.on('data', function(data) {
-  server_message = data.toString();
-  socket3.write('Client hello');
-  socket3.end();
-});
+  socket3.on('secureConnect', function() {
+    handshake_done = true;
+  });
 
-socket3.on('end', function() {
-  server.close();
-});
+  socket3.on('data', function(data) {
+    server_message = data.toString();
+    socket3.write('Client hello');
+    socket3.end();
+  });
+
+  socket3.on('end', endCallback);
+}
 
 process.on('exit', function() {
+  assert.equal(endCount, 3);
   assert.equal(handshake_done, true);
   assert.equal(server_handshake_done, true);
   assert.equal(client_message === expected_client_msg, true);