Skip to content

Commit b358467

Browse files
committed
Fix example: FileInputStream was never closed
From netty/netty@9acf130
1 parent c799de6 commit b358467

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/main/scala/com/github/kxbmap/netty/example/filetransfer/FileServer.scala

+3-1
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,11 @@ object FileServer extends App {
4747
(file.exists(), file.isFile) match {
4848
case (true, true) =>
4949
ctx.write(s"$file ${file.length()}\n")
50-
val region = new DefaultFileRegion(new FileInputStream(file).getChannel, 0, file.length())
50+
val fis = new FileInputStream(file)
51+
val region = new DefaultFileRegion(fis.getChannel, 0, file.length())
5152
ctx.write(region)
5253
ctx.writeAndFlush("\n")
54+
fis.close()
5355

5456
case (false, _) => ctx.writeAndFlush(s"File not found: $file\n")
5557
case (_, false) => ctx.writeAndFlush(s"Not a file: $file\n")

0 commit comments

Comments
 (0)