Skip to content
This repository was archived by the owner on May 14, 2024. It is now read-only.

Commit 7b869f4

Browse files
committed
Resolve issue #924
1 parent ac588a0 commit 7b869f4

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

.github/workflows/integration.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020

2121
services:
2222
openldap:
23-
image: ghcr.io/ldapjs/docker-test-openldap/openldap:2023-03-18
23+
image: ghcr.io/ldapjs/docker-test-openldap/openldap:2023-08-15
2424
ports:
2525
- 389:389
2626
- 636:636

docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
services:
22
openldap:
3-
image: ghcr.io/ldapjs/docker-test-openldap/openldap:2023-03-18
3+
image: ghcr.io/ldapjs/docker-test-openldap/openldap:2023-08-15
44
ports:
55
- 389:389
66
- 636:636

test-integration/client/issues.test.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,14 @@ const PORT = process.env.PORT || 389
1010
const baseURL = `${SCHEME}://${HOST}:${PORT}`
1111

1212
tap.test('modifyDN with long name (issue #480)', t => {
13-
const longStr = 'a292979f2c86d513d48bbb9786b564b3c5228146e5ba46f404724e322544a7304a2b1049168803a5485e2d57a544c6a0d860af91330acb77e5907a9e601ad1227e80e0dc50abe963b47a004f2c90f570450d0e920d15436fdc771e3bdac0487a9735473ed3a79361d1778d7e53a7fb0e5f01f97a75ef05837d1d5496fc86968ff47fcb64'
13+
// 2023-08-15: disabling this 265 character string until a bug can be
14+
// fixed in OpenLDAP. See https://github.com/ldapjs/docker-test-openldap/blob/d48bc2fb001b4ed9a152715ced4a2cb120439ec4/bootstrap/slapd-init.sh#L19-L31.
15+
// const longStr = 'a292979f2c86d513d48bbb9786b564b3c5228146e5ba46f404724e322544a7304a2b1049168803a5485e2d57a544c6a0d860af91330acb77e5907a9e601ad1227e80e0dc50abe963b47a004f2c90f570450d0e920d15436fdc771e3bdac0487a9735473ed3a79361d1778d7e53a7fb0e5f01f97a75ef05837d1d5496fc86968ff47fcb64'
16+
17+
// 2023-08-15: this 140 character string satisfies the original issue
18+
// (https://github.com/ldapjs/node-ldapjs/issues/480) and avoids a bug
19+
// in OpenLDAP 2.5.
20+
const longStr = '292979f2c86d513d48bbb9786b564b3c5228146e5ba46f404724e322544a7304a2b1049168803a5485e2d57a544c6a0d860af91330acb77e5907a9e601ad1227e80e0dc50ab'
1421
const targetDN = 'cn=Turanga Leela,ou=people,dc=planetexpress,dc=com'
1522
const client = ldapjs.createClient({ url: baseURL })
1623
client.bind('cn=admin,dc=planetexpress,dc=com', 'GoodNewsEveryone', bindHandler)

0 commit comments

Comments
 (0)