Skip to content

Commit 4bf1918

Browse files
authored
Add Peter Yu (yukw777) to core maintainers (Lightning-AI#2690)
1 parent cb0c6ad commit 4bf1918

File tree

2 files changed

+31
-29
lines changed

2 files changed

+31
-29
lines changed

README.md

Lines changed: 30 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
-->
2222
</div>
2323

24-
---
24+
---
2525
## Trending contributors
2626

2727
[![](https://sourcerer.io/fame/williamFalcon/pytorchlightning/pytorch-lightning/images/0)](https://sourcerer.io/fame/williamFalcon/pytorchlightning/pytorch-lightning/links/0)
@@ -99,22 +99,22 @@ class LitClassifier(pl.LightningModule):
9999
train_loader = DataLoader(MNIST(os.getcwd(), train=True, download=True, transform=transforms.ToTensor()), batch_size=32)
100100

101101
model = LitClassifier()
102-
trainer = pl.Trainer(gpus=8, precision=16)
103-
trainer.fit(model, train_loader)
102+
trainer = pl.Trainer(gpus=8, precision=16)
103+
trainer.fit(model, train_loader)
104104
```
105105

106-
Other examples:
107-
[MNIST hello world](https://colab.research.google.com/drive/1F_RNcHzTfFuQf-LeKvSlud6x7jXYkG31#scrollTo=gEulmrbxwaYL)
108-
[GAN](https://colab.research.google.com/drive/1F_RNcHzTfFuQf-LeKvSlud6x7jXYkG31#scrollTo=P0bSmCw57aV5)
109-
[BERT](https://colab.research.google.com/drive/1F_RNcHzTfFuQf-LeKvSlud6x7jXYkG31#scrollTo=7uQVI-xv9Ddj)
110-
[DQN](https://colab.research.google.com/drive/1F_RNcHzTfFuQf-LeKvSlud6x7jXYkG31#scrollTo=NWvMLBDySQI5)
111-
[MNIST on TPUs](https://colab.research.google.com/drive/1-_LKx4HwAxl5M6xPJmqAAu444LTDQoa3)
106+
Other examples:
107+
[MNIST hello world](https://colab.research.google.com/drive/1F_RNcHzTfFuQf-LeKvSlud6x7jXYkG31#scrollTo=gEulmrbxwaYL)
108+
[GAN](https://colab.research.google.com/drive/1F_RNcHzTfFuQf-LeKvSlud6x7jXYkG31#scrollTo=P0bSmCw57aV5)
109+
[BERT](https://colab.research.google.com/drive/1F_RNcHzTfFuQf-LeKvSlud6x7jXYkG31#scrollTo=7uQVI-xv9Ddj)
110+
[DQN](https://colab.research.google.com/drive/1F_RNcHzTfFuQf-LeKvSlud6x7jXYkG31#scrollTo=NWvMLBDySQI5)
111+
[MNIST on TPUs](https://colab.research.google.com/drive/1-_LKx4HwAxl5M6xPJmqAAu444LTDQoa3)
112112

113113
## What is it?
114114
[READ THIS QUICK START PAGE](https://pytorch-lightning.readthedocs.io/en/stable/new-project.html)
115115

116116
Lightning is a way to organize your PyTorch code to decouple the science code from the engineering.
117-
It's more of a PyTorch style-guide than a framework.
117+
It's more of a PyTorch style-guide than a framework.
118118

119119
In Lightning, you organize your code into 3 distinct categories:
120120

@@ -130,16 +130,16 @@ The rest of the code is automated by the [Trainer](https://pytorch-lightning.rea
130130
![PT to PL](docs/source/_images/lightning_module/pt_trainer.png)
131131

132132
## Testing Rigour
133-
All the automated code by the Trainer is [tested rigorously with every new PR](https://github.com/PyTorchLightning/pytorch-lightning/tree/master/tests).
133+
All the automated code by the Trainer is [tested rigorously with every new PR](https://github.com/PyTorchLightning/pytorch-lightning/tree/master/tests).
134134

135-
For every PR we test all combinations of:
136-
- PyTorch 1.3, 1.4, 1.5
137-
- Python 3.6, 3.7, 3.8
138-
- Linux, OSX, Windows
139-
- Multiple GPUs
135+
For every PR we test all combinations of:
136+
- PyTorch 1.3, 1.4, 1.5
137+
- Python 3.6, 3.7, 3.8
138+
- Linux, OSX, Windows
139+
- Multiple GPUs
140140

141-
**How does performance compare with vanilla PyTorch?**
142-
We have tests to ensure we get the EXACT same results in under 600 ms difference per epoch. In reality, lightning adds about a 300 ms overhead per epoch.
141+
**How does performance compare with vanilla PyTorch?**
142+
We have tests to ensure we get the EXACT same results in under 600 ms difference per epoch. In reality, lightning adds about a 300 ms overhead per epoch.
143143
[Check out the parity tests here](https://github.com/PyTorchLightning/pytorch-lightning/tree/master/benchmarks).
144144

145145
Overall, Lightning guarantees rigorously tested, correct, modern best practices for the automated parts.
@@ -181,7 +181,7 @@ This is how lightning separates the science (red) from engineering (blue).
181181
If your code is not a huge mess you should be able to organize it into a LightningModule in less than 1 hour.
182182
If your code IS a mess, then you needed to clean up anyhow ;)
183183

184-
[Check out this step-by-step guide](https://towardsdatascience.com/from-pytorch-to-pytorch-lightning-a-gentle-introduction-b371b7caaf09).
184+
[Check out this step-by-step guide](https://towardsdatascience.com/from-pytorch-to-pytorch-lightning-a-gentle-introduction-b371b7caaf09).
185185
[Or watch this video](https://www.youtube.com/watch?v=QHww1JH7IDU).
186186

187187

@@ -192,7 +192,7 @@ If your code IS a mess, then you needed to clean up anyhow ;)
192192
Although your research/production project might start simple, once you add things like GPU AND TPU training, 16-bit precision, etc, you end up spending more time engineering than researching. Lightning automates AND rigorously tests those parts for you.
193193

194194
## Support
195-
- [8 core contributors](https://pytorch-lightning.readthedocs.io/en/latest/governance.html) who are all a mix of professional engineers, Research Scientists, Ph.D. students from top AI labs.
195+
- [8 core contributors](https://pytorch-lightning.readthedocs.io/en/latest/governance.html) who are all a mix of professional engineers, Research Scientists, Ph.D. students from top AI labs.
196196
- 100+ community contributors.
197197

198198
Lightning is also part of the [PyTorch ecosystem](https://pytorch.org/ecosystem/) which requires projects to have solid testing, documentation and support.
@@ -335,7 +335,7 @@ Lightning has out-of-the-box integration with the popular logging/visualizing fr
335335
- [Neptune.ai](https://neptune.ai/)
336336
- [Comet.ml](https://www.comet.ml/site/)
337337
- [Wandb](https://www.wandb.com/)
338-
- ...
338+
- ...
339339

340340
![tensorboard-support](docs/source/_images/general/tf_loss.png)
341341

@@ -393,27 +393,27 @@ If you have any questions, feel free to:
393393
---
394394

395395
## FAQ
396-
**How do I use Lightning for rapid research?**
396+
**How do I use Lightning for rapid research?**
397397
[Here's a walk-through](https://pytorch-lightning.readthedocs.io/en/latest/introduction_guide.html)
398398

399-
**Why was Lightning created?**
399+
**Why was Lightning created?**
400400
Lightning has 3 goals in mind:
401401

402402
1. Maximal flexibility while abstracting out the common boilerplate across research projects.
403403
2. Reproducibility. If all projects use the LightningModule template, it will be much much easier to understand what's going on and where to look! It will also mean every implementation follows a standard format.
404404
3. Democratizing PyTorch power-user features. Distributed training? 16-bit? know you need them but don't want to take the time to implement? All good... these come built into Lightning.
405405

406-
**How does Lightning compare with Ignite and fast.ai?**
406+
**How does Lightning compare with Ignite and fast.ai?**
407407
[Here's a thorough comparison](https://medium.com/@_willfalcon/pytorch-lightning-vs-pytorch-ignite-vs-fast-ai-61dc7480ad8a).
408408

409-
**Is this another library I have to learn?**
409+
**Is this another library I have to learn?**
410410
Nope! We use pure Pytorch everywhere and don't add unnecessary abstractions!
411411

412-
**Are there plans to support Python 2?**
412+
**Are there plans to support Python 2?**
413413
Nope.
414414

415-
**Are there plans to support virtualenv?**
416-
Nope. Please use anaconda or miniconda.
415+
**Are there plans to support virtualenv?**
416+
Nope. Please use anaconda or miniconda.
417417
```bash
418418
conda activate my_env
419419
pip install pytorch-lightning
@@ -457,10 +457,11 @@ pip install https://github.com/PytorchLightning/pytorch-lightning/archive/0.X.Y.
457457
- Tullie Murrell [(tullie)](https://github.com/tullie)
458458
- Adrian Wälchli [(awaelchli)](https://github.com/awaelchli)
459459
- Nicki Skafte [(skaftenicki)](https://github.com/SkafteNicki)
460+
- Peter Yu [(yukw777)](https://github.com/yukw777)
460461

461462
---
462463

463-
#### Funding
464+
#### Funding
464465
Building open-source software with only a few part-time people is hard! We've secured funding to make sure we can
465466
hire a full-time staff, attend conferences, and move faster through implementing features you request.
466467

docs/source/governance.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,4 @@ Core Maintainers
1717
- Tullie Murrell (`tullie <https://github.com/tullie>`_)
1818
- Adrian Wälchli (`awaelchli <https://github.com/awaelchli>`_)
1919
- Nicki Skafte (`skaftenicki <https://github.com/SkafteNicki>`_)
20+
- Peter Yu (`yukw777 <https://github.com/yukw777>`_)

0 commit comments

Comments
 (0)