Skip to content

Commit 64046e9

Browse files
[Driver] Use a range constructor of StringSet (NFC) (#133201)
This patch uses a range constructor to collapse: llvm::StringSet<> Dest; for (const auto &S : Src) Dest.insert(S); down to: llvm::StringSet<> Dest(llvm::from_range, Src);
1 parent d58f572 commit 64046e9

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

clang/lib/Driver/Job.cpp

+1-3
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,7 @@ void Command::buildArgvForResponseFile(
140140
return;
141141
}
142142

143-
llvm::StringSet<> Inputs;
144-
for (const auto *InputName : InputFileList)
145-
Inputs.insert(InputName);
143+
llvm::StringSet<> Inputs(llvm::from_range, InputFileList);
146144
Out.push_back(Executable);
147145

148146
if (PrependArg)

clang/lib/Driver/Multilib.cpp

+2-6
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,7 @@ void Multilib::print(raw_ostream &OS) const {
6060
bool Multilib::operator==(const Multilib &Other) const {
6161
// Check whether the flags sets match
6262
// allowing for the match to be order invariant
63-
llvm::StringSet<> MyFlags;
64-
for (const auto &Flag : Flags)
65-
MyFlags.insert(Flag);
63+
llvm::StringSet<> MyFlags(llvm::from_range, Flags);
6664

6765
for (const auto &Flag : Other.Flags)
6866
if (!MyFlags.contains(Flag))
@@ -272,9 +270,7 @@ bool MultilibSet::select(
272270

273271
llvm::StringSet<>
274272
MultilibSet::expandFlags(const Multilib::flags_list &InFlags) const {
275-
llvm::StringSet<> Result;
276-
for (const auto &F : InFlags)
277-
Result.insert(F);
273+
llvm::StringSet<> Result(llvm::from_range, InFlags);
278274
for (const FlagMatcher &M : FlagMatchers) {
279275
std::string RegexString(M.Match);
280276

0 commit comments

Comments
 (0)