Skip to content

Commit e8e05c3

Browse files
committed
[MC] Remove the MCAsmLayout parameter from MCAsmBackend::finishLayout
And remove unnecessary MCAssembler::finishLayout.
1 parent a7ddd60 commit e8e05c3

File tree

5 files changed

+5
-17
lines changed

5 files changed

+5
-17
lines changed

llvm/include/llvm/MC/MCAsmBackend.h

+1-3
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ class MCFragment;
2424
class MCLEBFragment;
2525
class MCRelaxableFragment;
2626
class MCSymbol;
27-
class MCAsmLayout;
2827
class MCAssembler;
2928
class MCContext;
3029
struct MCDwarfFrameInfo;
@@ -219,8 +218,7 @@ class MCAsmBackend {
219218
const MCSubtargetInfo *STI) const = 0;
220219

221220
/// Give backend an opportunity to finish layout after relaxation
222-
virtual void finishLayout(MCAssembler const &Asm,
223-
MCAsmLayout &Layout) const {}
221+
virtual void finishLayout(MCAssembler const &Asm) const {}
224222

225223
/// Handle any target-specific assembler flags. By default, do nothing.
226224
virtual void handleAssemblerFlag(MCAssemblerFlag Flag) {}

llvm/include/llvm/MC/MCAssembler.h

-3
Original file line numberDiff line numberDiff line change
@@ -210,9 +210,6 @@ class MCAssembler {
210210
bool relaxCVDefRange(MCCVDefRangeFragment &DF);
211211
bool relaxPseudoProbeAddr(MCPseudoProbeAddrFragment &DF);
212212

213-
/// finishLayout - Finalize a layout, including fragment lowering.
214-
void finishLayout(MCAsmLayout &Layout);
215-
216213
std::tuple<MCValue, uint64_t, bool>
217214
handleFixup(MCFragment &F, const MCFixup &Fixup, const MCSubtargetInfo *STI);
218215

llvm/lib/MC/MCAssembler.cpp

+1-6
Original file line numberDiff line numberDiff line change
@@ -984,7 +984,7 @@ void MCAssembler::layout(MCAsmLayout &Layout) {
984984
dump(); });
985985

986986
// Finalize the layout, including fragment lowering.
987-
finishLayout(Layout);
987+
getBackend().finishLayout(*this);
988988

989989
DEBUG_WITH_TYPE("mc-dump", {
990990
errs() << "assembler backend - final-layout\n--\n";
@@ -1350,11 +1350,6 @@ bool MCAssembler::layoutOnce() {
13501350
return Changed;
13511351
}
13521352

1353-
void MCAssembler::finishLayout(MCAsmLayout &Layout) {
1354-
assert(getBackendPtr() && "Expected assembler backend");
1355-
getBackend().finishLayout(*this, Layout);
1356-
}
1357-
13581353
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
13591354
LLVM_DUMP_METHOD void MCAssembler::dump() const{
13601355
raw_ostream &OS = errs();

llvm/lib/Target/Hexagon/MCTargetDesc/HexagonAsmBackend.cpp

+1-2
Original file line numberDiff line numberDiff line change
@@ -703,8 +703,7 @@ class HexagonAsmBackend : public MCAsmBackend {
703703
return true;
704704
}
705705

706-
void finishLayout(MCAssembler const &Asm,
707-
MCAsmLayout &Layout) const override {
706+
void finishLayout(MCAssembler const &Asm) const override {
708707
SmallVector<MCFragment *> Frags;
709708
for (MCSection &Sec : Asm) {
710709
Frags.clear();

llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp

+2-3
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ class X86AsmBackend : public MCAsmBackend {
202202
bool padInstructionEncoding(MCRelaxableFragment &RF, MCCodeEmitter &Emitter,
203203
unsigned &RemainingSize) const;
204204

205-
void finishLayout(MCAssembler const &Asm, MCAsmLayout &Layout) const override;
205+
void finishLayout(const MCAssembler &Asm) const override;
206206

207207
unsigned getMaximumNopSize(const MCSubtargetInfo &STI) const override;
208208

@@ -857,8 +857,7 @@ bool X86AsmBackend::padInstructionEncoding(MCRelaxableFragment &RF,
857857
return Changed;
858858
}
859859

860-
void X86AsmBackend::finishLayout(MCAssembler const &Asm,
861-
MCAsmLayout &Layout) const {
860+
void X86AsmBackend::finishLayout(MCAssembler const &Asm) const {
862861
// See if we can further relax some instructions to cut down on the number of
863862
// nop bytes required for code alignment. The actual win is in reducing
864863
// instruction count, not number of bytes. Modern X86-64 can easily end up

0 commit comments

Comments
 (0)