Bug in FileOutputBuffer.cpp ?

[chestnykh]

In 6814232#diff-149a9a5aa83dbeebf5b0d6e1ead08df05664cd4f201fc02ed749555278406d41

the following code was added:

    if (Flags & F_no_mmap)
      return createInMemoryBuffer(Path, Size, Mode);
    else
      return createOnDiskBuffer(Path, Size, Mode);

But createInMemoryBuffer uses mmap and if i correct we have to use createOnDiskBuffer in case F_no_mmap is set

CC: @terrelln @MaskRay

[MaskRay]

It seems that we could rename F_no_mmap to F_mmap. Only lld appears to use this bit. There should be no behavior change for users that do not set the flag.

    /// Don't use mmap and instead write an in-memory buffer to a file when this
    /// buffer is closed.
    F_no_mmap = 2,