[clangd] Completion key ArgumentLists doesn't take precedence over --function-arg-placeholders

[tongshengw]

Thank you Clangd team for this incredible piece of software.

Quite a minor issue:

It seems that ArgumentLists should take precedence over --function-arg-placeholders as suggested in:
#63565 (comment)

ArgumentLists does not take precedence at the moment.

I was using ArgumentLists : "None" with --function-arg-placeholders=0, and function parenthesis generated. Removing --function-arg-placeholders=0 fixes this issue.

Expected behaviour:

ArgumentLists: "None" used with --function-arg-placeholders=0 prioritises ArgumentLists:"None".

clangd version 21.0.0git (https://github.com/llvm/llvm-project.git 2206e15)
Features: mac+debug+xpc
Platform: arm64-apple-darwin24.4.0

Would be great to know if this is intended behaviour or a bug. I will attempt to fix this if it is not intended behaviour.

Thanks! :)

[llvmbot]

@llvm/issue-subscribers-clangd

Author: Tongsheng Wu (tongshengw)

Thank you Clangd team for this incredible piece of software.

Quite a minor issue:

It seems that ArgumentLists should take precedence over --function-arg-placeholders as suggested in:
#63565 (comment)

ArgumentLists does not take precedence at the moment.

I was using ArgumentLists : "None" with --function-arg-placeholders=0, and function parenthesis generated. Removing --function-arg-placeholders=0 fixes this issue.

Expected behaviour:

ArgumentLists: "None" used with --function-arg-placeholders=0 prioritises ArgumentLists:"None".

clangd version 21.0.0git (https://github.com/llvm/llvm-project.git 2206e15)
Features: mac+debug+xpc
Platform: arm64-apple-darwin24.4.0

Would be great to know if this is intended behaviour or a bug. I will attempt to fix this if it is not intended behaviour.

Thanks! :)

[HighCommander4]

ArgumentLists does not take precedence at the moment.

[...]

Would be great to know if this is intended behaviour or a bug.

It was my hope, at the time of writing the comment you linked to, that ArgumentLists would take precedence over --function-arg-placeholders.

However, during the review of the patch, we discovered that this is not how existing flags which are present both on the command line and the config file, such as --background-index, work.

So, for consistency, we changed course and let --function-arg-placeholders take precedence.