You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The component overrides it and shows only rect-json-viewer.
I could manually set each style element but my target here is to have the same style as rs-input elements, included hover and other actions css. Being able to do something like:
extendClassname = "rs-input anotherClass" would save a considerable amount of time and help to unify the code.
I could try to do a PR regarding this issue if you're ok to add a new prop!
On another note, there is another fork that seems more receptive to feedback as it does allow reporting of issues (https://github.com/TexteaInc/json-viewer), although not sure how much divergence with the officially recommended fork. cc @pionxzh, if you care to elaborate.
Thanks for mentioning our repo. I can provide some insights:
TexteaInc/json-viewer aims to cover most features of mac-s-g/react-json-view and has added several useful enhancements. It's more like "inspired by" mac-s-g/react-json-view instead of a fork.
We welcome issue reports and feature requests. However, considering my current focus and limited time for open source contributions, I can only promise that issues will be prioritized and fixed within 3-10 days.
Regarding the concern you mentioned, it's a dispute between an employer and a former employee. You can still use the library without any concerns.
himself65/rich-data is also a great library for those who want to fully customize features and layout. You can make the decision based on your requirements.
Activity
lveillard commentedon Jun 16, 2020
I subscribe to this! I would love to be able to add classNames to the json viewer object.
When i do this:
The component overrides it and shows only rect-json-viewer.
I could manually set each style element but my target here is to have the same style as rs-input elements, included hover and other actions css. Being able to do something like:
extendClassname = "rs-input anotherClass" would save a considerable amount of time and help to unify the code.
I could try to do a PR regarding this issue if you're ok to add a new prop!
lveillard commentedon Jun 16, 2020
Quick win for those wondering:
Does the trick
obadakhalili commentedon Jul 16, 2021
Will this be considered? It should be a minimal requirement to have. Thanks
feat: add `className` prop
className
prop #377renamartins commentedon Apr 5, 2024
Since this repository is dead, I looked at the fork suggested by 443465e
Looks like I cannot create issues in that fork. @Kikobeats, I'm tagging you since you seem to be one of the maintainers of https://github.com/microlinkhq/react-json-view. Two questions for you:
is there a reason that repository does not accept tracking of issues?
is it possible this issue here (and its fix PR feat: add
className
prop #377) be applied to https://github.com/microlinkhq/react-json-view ?On another note, there is another fork that seems more receptive to feedback as it does allow reporting of issues (https://github.com/TexteaInc/json-viewer), although not sure how much divergence with the officially recommended fork. cc @pionxzh, if you care to elaborate.
Update: I was going through some issues and came across himself65/rich-data#10. Not exactly sure what is going on there, but from first glance it seems best to avoid https://github.com/TexteaInc/json-viewer to avoid trouble.
pionxzh commentedon Apr 5, 2024
Thanks for mentioning our repo. I can provide some insights:
mac-s-g/react-json-view
and has added several useful enhancements. It's more like "inspired by"mac-s-g/react-json-view
instead of a fork.himself65/rich-data
is also a great library for those who want to fully customize features and layout. You can make the decision based on your requirements.Thank you for your understanding. 🙏