File tree 2 files changed +5
-25
lines changed
2 files changed +5
-25
lines changed Original file line number Diff line number Diff line change 12
12
13
13
use Magento \Framework \App \Config \ScopeConfigInterface ;
14
14
use Magento \Store \Model \ScopeInterface ;
15
+ use Magento \Framework \View \Asset \Config as MagentoConfig ;
15
16
16
17
class Config
17
18
{
@@ -68,28 +69,6 @@ public function isEnabled(string $storeId = null): bool
68
69
return (bool )$ this ->getConfig (self ::XML_PATH_EXTENSION_ENABLED , $ storeId );
69
70
}
70
71
71
- /**
72
- * Retrieve true if js files merged
73
- *
74
- * @param string|null $storeId
75
- * @return bool
76
- */
77
- public function isMergeFiles (string $ storeId = null ): bool
78
- {
79
- return (bool )$ this ->getConfig (self ::XML_PATH_MERGE_FILES , $ storeId );
80
- }
81
-
82
- /**
83
- * Retrieve true if js files minified
84
- *
85
- * @param string|null $storeId
86
- * @return bool
87
- */
88
- public function isMinifyFiles (string $ storeId = null ): bool
89
- {
90
- return (bool )$ this ->getConfig (self ::XML_PATH_MINIFY_FILES , $ storeId );
91
- }
92
-
93
72
/**
94
73
* Retrieve true if deferred is enabled
95
74
*
@@ -131,7 +110,7 @@ public function getIgnoreJavaScript(string $storeId = null): string
131
110
*/
132
111
public function isBundlingEnabled (string $ storeId = null ): bool
133
112
{
134
- return (bool )$ this ->getConfig (self :: XML_PATH_JAVASCRIPT_BUNDLING_ENABLED , $ storeId );
113
+ return (bool )$ this ->getConfig (MagentoConfig:: XML_PATH_JS_BUNDLING , $ storeId );
135
114
}
136
115
137
116
/**
Original file line number Diff line number Diff line change 36
36
<label >Minify JavaScript Files</label >
37
37
<source_model >Magento\Config\Model\Config\Source\Yesno</source_model >
38
38
<backend_model >Magefan\RocketJavaScript\Model\Config\Backend\DevSettings</backend_model >
39
- <comment >Minification is not applied in developer mode.</comment >
39
+ <comment >Minification is not applied in developer mode. Static content deployment is a requirement after option change </comment >
40
40
</field >
41
41
</group >
42
42
<group id =" deferred_javascript" translate =" label" type =" text" sortOrder =" 15" showInDefault =" 1" showInWebsite =" 1" showInStore =" 1" >
67
67
<label >Enabled</label >
68
68
<source_model >Magento\Config\Model\Config\Source\Yesno</source_model >
69
69
<backend_model >Magefan\RocketJavaScript\Model\Config\Backend\DevSettings</backend_model >
70
+ <comment >Static content deployment is a requirement after option change</comment >
70
71
</field >
71
72
<field id =" enable_js_bundling_optimization" showInDefault =" 1" showInStore =" 1" showInWebsite =" 1" sortOrder =" 20" translate =" label" type =" select" canRestore =" 1" >
72
73
<label >Enable Bundling Optimization</label >
73
74
<depends >
74
75
<field id =" enabled" >1</field >
75
76
</depends >
76
- <comment >Please note that this option only works with enabled JavaScript Bundling (Configuration > Advanced > Developer > JavaScript Settings > Enable JavaScript Bundling). </comment >
77
+ <comment >Static content deployment is a requirement after option change </comment >
77
78
<source_model >Magento\Config\Model\Config\Source\Yesno</source_model >
78
79
</field >
79
80
<field id =" included_in_bundling" showInDefault =" 1" showInStore =" 1" showInWebsite =" 1" sortOrder =" 30" translate =" label" type =" textarea" canRestore =" 1" >
You can’t perform that action at this time.
0 commit comments