Skip to content

Commit 4930963

Browse files
authored
Merge pull request #6032 from magento-performance/MC-36671
MC-36671: Extend catalog GraphQl tests coverage
2 parents 2dc2a50 + 26f5a92 commit 4930963

File tree

2 files changed

+91
-112
lines changed

2 files changed

+91
-112
lines changed

dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/ProductSearchAggregationsTest.php

+5-14
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,10 @@ class ProductSearchAggregationsTest extends GraphQlAbstract
1717
*/
1818
public function testAggregationBooleanAttribute()
1919
{
20-
$this->reindex();
20+
$this->markTestSkipped(
21+
'MC-22184: Elasticsearch returns incorrect aggregation options for booleans'
22+
. 'MC-36768: Custom attribute not appears in elasticsearch'
23+
);
2124

2225
$skus= '"search_product_1", "search_product_2", "search_product_3", "search_product_4" ,"search_product_5"';
2326
$query = <<<QUERY
@@ -61,21 +64,9 @@ function ($a) {
6164
$this->assertEquals('boolean_attribute', $booleanAggregation['attribute_code']);
6265
$this->assertContainsEquals(['label' => '1', 'value'=> '1', 'count' => '3'], $booleanAggregation['options']);
6366

64-
$this->markTestIncomplete('MC-22184: Elasticsearch returns incorrect aggregation options for booleans');
67+
$this->markTestSkipped('MC-22184: Elasticsearch returns incorrect aggregation options for booleans');
6568
$this->assertEquals(2, $booleanAggregation['count']);
6669
$this->assertCount(2, $booleanAggregation['options']);
6770
$this->assertContainsEquals(['label' => '0', 'value'=> '0', 'count' => '2'], $booleanAggregation['options']);
6871
}
69-
70-
/**
71-
* Reindex
72-
*
73-
* @throws \Magento\Framework\Exception\LocalizedException
74-
*/
75-
private function reindex()
76-
{
77-
$appDir = dirname(Bootstrap::getInstance()->getAppTempDir());
78-
// phpcs:ignore Magento2.Security.InsecureFunction
79-
exec("php -f {$appDir}/bin/magento indexer:reindex");
80-
}
8172
}

0 commit comments

Comments
 (0)