Skip to content

Increase DB_MAX_VARCHAR_LENGTH to 1024 #30327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from
Open

Increase DB_MAX_VARCHAR_LENGTH to 1024 #30327

wants to merge 4 commits into from
+1 −1

Conversation

geryjuhasz
Copy link

Increase DB_MAX_VARCHAR_LENGTH to 1024

Description (*)

Increase the length to fix the issue described here #15679

Fixed Issues (if relevant)

  1. Fixes Attribute image exceeded max length in row(s) when importing images from Amazon.com with CSV file #15679

Manual testing scenarios (*)

Log into backend panel
Go to System->Import
Select products as Entity Type option, select Add/Update as Import Behavior, Select Stop on Error, Allowed Errors Count is 10,Field separator is Comma(,) ,Multiple value separator is Comma(,) , Fields enclosure filed is empty.
4.Select File to Import
5.Images File Directory left blank (As the images were going to fetch from Amazon.com)
6.Click Check Data

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 2, 2020

Hi @geryjuhasz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Oct 5, 2020
@orlangur orlangur self-assigned this Oct 8, 2020
@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Progress: review and removed Progress: pending review labels Nov 30, 2020
@sdzhepa sdzhepa removed Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Nov 30, 2020
@coderimus coderimus self-assigned this Feb 1, 2021
@coderimus
Copy link
Contributor

@magento run all tests

@coderimus
Copy link
Contributor

@magento run Functional Tests EE

1 similar comment
@coderimus
Copy link
Contributor

@magento run Functional Tests EE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@coderimus coderimus

Labels
Component: ImportExport Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attribute image exceeded max length in row(s) when importing images from Amazon.com with CSV file
6 participants
@geryjuhasz @coderimus @orlangur @sdzhepa @sidolov @magento-engcom-team