-
Notifications
You must be signed in to change notification settings - Fork 9.4k
optimized configurable product indexing #24962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimized configurable product indexing #24962
Conversation
Hi @ravi-chandra3197. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Resolve this issue using single PR #24535, #15609, #14443 Negative prices in layered navigation #24535 Magento 2.2.4 Product sorting list by price on category page wrong when configurable product has special price set by mass action. #15609 Final min_price and max_price calculation on configurable product with special price #14443 |
The mentioned expression doesn't result in "0 - 0 + X" every time, i.price field contains base product price, but i.min_price field contains base price plus price of required custom options. |
Hello @dhorytskyi step-1: create any configurable product in M1 set price and special price |
We are having the same issue - I thought it was because of M1 import but other items updated via api are also showing the issue . |
This has been pending for 6 months now. Any chance this can be merged? |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Could you review failing integration tests?
According to test results - seems like your change does some regression in specific cases and solution should be improved. -
After fixing failing existing tests, could you cover your changes with some kind of test?
Hello @ihor-sviziev I am working on failing integration tests |
@ravi-chandra3197 will you be able to update your PR? Or maybe you have some questions / need some help? |
@ihor-sviziev I have need help to fix integration tests. |
@engcom-Charlie could you help with failing tests? |
Hello @ravi-chandra3197, will try to help you with Integration Tests. |
@engcom-Hotel make sure that these changes didn't break some functionality. |
@magento run all tests |
Hello @ravi-chandra3197 @ihor-sviziev. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ravi-chandra3197,
Could you update your solution to be compatible with the cases when tests are failing?
|
Looks like we have another PR that fixes the same issue. #26810 |
@ravi-chandra3197 will you be able to update your PR? |
@ravi-chandra3197 I am closing this PR now due to inactivity. |
Hi @ravi-chandra3197, thank you for your contribution! |
Description (*)
optimized configurable product indexing (Fixed Negative min_price and max_price issue after migration)
Fixed Issues (if relevant)
Fixes #24535
Fixes #15609
Fixes #14443
Fixes #24953
Manual testing scenarios (*)
Questions or comments
Testing with sample data min_price equation calculate like this
min_price = i.min_price - i.price + io.min_price
which become 44 = 0 - 0 + 44
i.max_price - i.price + io.max_price
44 = 0 - 0 + 44
there is no meaning to use configurable price and min_price in the calculation
(Magento2 Not allow to add price or special price it's by default 0 )
Fixed Negative min_price and max_price issue after migration
Magento1 allows adding price and special prices for the configurable product which create an issue for calculating min_price and max_price in Magento2
with the above solution, indexing becomes faster to reduce calculation for each product min and max price and fixed
Contribution checklist (*)