[Modularity] Layered navigation may be broken if CatalogSearch is disabled

[magento-engcom-team]

Steps to reproduce:

• Install Magento with disabled CatalogSearch module
• Open category page and use layered navigation

Actual result:
(x) Layered navigation will contain bugs that have already been fixed, and would not be reproducible with installed CatalogSearch (e.g. this one MAGETWO-63175)

Expected result:
(/) Layered navigation should work correctly with or without CatalogSearch installed

Additional details:
There is hidden modularity issue between Catalog and CatalogSearch.

\Magento\Catalog\Model\Layer\FilterList has a list of default filters declared as private variable:

    protected $filterTypes = <
        self::CATEGORY_FILTER  => \Magento\Catalog\Model\Layer\Filter\Category::class,
        self::ATTRIBUTE_FILTER => \Magento\Catalog\Model\Layer\Filter\Attribute::class,
        self::PRICE_FILTER     => \Magento\Catalog\Model\Layer\Filter\Price::class,
        self::DECIMAL_FILTER   => \Magento\Catalog\Model\Layer\Filter\Decimal::class,
    >;
{code}

Then in constructor these filters are overridden by the ones specified in `di.xml` by other modules:
{code:php}
        /*** Override default filter type models **/
        $this->filterTypes = array_merge($this->filterTypes, $filters);

CatalogSearch overrides all filters declared in Catalog module. So with installed CatalogSearch all default filters are overridden and this is setup we are always testing. If CatalogSearch is disabled - we fall back to the filters which we never test and those filters contain bugs, which have been fixed in CatalogSearch.

[magento-engcom-team]

The issue was exported from the internal JIRA. The link to the original JIRA issue: https://jira.corp.magento.com/browse/MC-22000

[m2-assistant]

Hi @magento-engcom-team. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[magento-engcom-team]

✅ Confirmed by @magento-engcom-team
Thank you for verifying the issue. Based on the provided information internal tickets MC-22000 were created

Issue Available: @magento-engcom-team, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.