Skip to content

module.xml file improvements for Magento_ConfigurableProductGraphQl, Magento_MsrpConfigurableProduct, Magento_NewRelicReporting & Magento_Swatches modules. #30638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from
Open

module.xml file improvements for Magento_ConfigurableProductGraphQl, Magento_MsrpConfigurableProduct, Magento_NewRelicReporting & Magento_Swatches modules. #30638

wants to merge 2 commits into from

Conversation

sanganinamrata
Copy link
Member

@sanganinamrata sanganinamrata commented Oct 24, 2020 •
edited by m2-assistant bot
Loading

Description (*)

Removed <module name=“Magento_Catalog”/> dependency from Magento_ConfigurableProductGraphQl, Magento_MsrpConfigurableProduct, Magento_NewRelicReporting & Magento_Swatches modules. as those modules are already dependent on Magento_ConfigurableProduct, which is then dependent on Magento_Catalog. So need to add those dependencies.

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] module.xml file improvements for Magento_ConfigurableProductGraphQl, Magento_MsrpConfigurableProduct, Magento_NewRelicReporting & Magento_Swatches modules. #30675: module.xml file improvements for Magento_ConfigurableProductGraphQl, Magento_MsrpConfigurableProduct, Magento_NewRelicReporting & Magento_Swatches modules.

module.xml file improvements for Magento_ConfigurableProductGraphQl, …
778be28 
…Magento_MsrpConfigurableProduct, Magento_NewRelicReporting & Magento_Swatches modules.
@m2-assistant
Copy link

m2-assistant bot commented Oct 24, 2020

Hi @sanganinamrata. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@rogyar
Copy link
Contributor

rogyar commented Oct 24, 2020

@magento run all tests

@rogyar rogyar self-assigned this Oct 24, 2020
@pratiksangani pratiksangani mentioned this pull request Oct 24, 2020
Open
5 tasks
@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Oct 27, 2020
@sidolov
Copy link
Contributor

sidolov commented Oct 27, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Oct 27, 2020
Open
4 tasks
@rogyar
Copy link
Contributor

rogyar commented Oct 30, 2020

@magento run Functional Tests EE

@m2-assistant m2-assistant bot mentioned this pull request Oct 30, 2020
Closed
4 tasks
@rogyar rogyar added the Cleanup label Nov 2, 2020
@ghost ghost removed the Progress: pending review label Nov 2, 2020
@rogyar rogyar added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Progress: pending review labels Nov 2, 2020
@ghost ghost added the Progress: review label Nov 2, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8418 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

Manual QA not applicable. Moved to Extended Testing column

@engcom-Charlie engcom-Charlie self-assigned this Dec 21, 2022
@engcom-Charlie engcom-Charlie removed their assignment Dec 22, 2022
@engcom-Lima engcom-Lima self-assigned this Aug 8, 2023
@engcom-Delta
Copy link
Contributor

@magento run all tests

@magento-automated-testing Magento Automated Testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Delta engcom-Delta self-assigned this Dec 29, 2023
@engcom-Delta
Copy link
Contributor

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Manual testing scenario:

Go to the paths

  1. app/code/Magento/ConfigurableProductGraphQl/etc/module.xml
  2. app/code/Magento/MsrpConfigurableProduct/etc/module.xml
  3. app/code/Magento/NewRelicReporting/etc/module.xml
  4. app/code/Magento/Swatches/etc/module.xml
  5. Verify Removed dependency

Before: ✖️ 

Screenshot 2024-01-03 at 11 20 15 AM Screenshot 2024-01-03 at 11 21 32 AM Screenshot 2024-01-03 at 11 22 14 AM Screenshot 2024-01-03 at 11 22 46 AM

After: ✔️  

Screenshot 2024-01-03 at 4 26 03 PM Screenshot 2024-01-03 at 4 26 43 PM Screenshot 2024-01-03 at 4 28 45 PM Screenshot 2024-01-03 at 4 29 15 PM

Builds are failed. Hence, moving this PR to Extended Testing.

@engcom-Dash engcom-Dash self-assigned this Oct 3, 2024
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Integration Tests, Functional Tests EE, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

engcom-Dash commented Oct 3, 2024 •
edited
Loading

The Functional B2B test failures are different in recent 2 builds with a known issue. Seems to be flaky, hence moving it to Merge in Progress.
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/30638/067553cfed1c9017791005855fe35b94/Functional/allure-report-b2b/index.html#categories/39002bb4b823f2d59e22404a186a7115/a076bf0024a61f95/
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/30638/ef8c95512fa8569aba463b1886e207a8/Functional/allure-report-b2b/index.html#categories/16b25a50b4a8b68f5548cdba82ebd5f8/a67940e2aee757d1/
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Delta engcom-Delta

@engcom-Foxtrot engcom-Foxtrot

@engcom-Lima engcom-Lima

@engcom-Dash engcom-Dash

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: ConfigurableProductGraphQl Component: MsrpConfigurableProduct Component: NewRelicReporting Component: Swatches Event: MageCONF CD 2020 Priority: P3 May be fixed according to the position in the backlog. Progress: ready for testing Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
Status: Merge in Progress
Milestone
No milestone
10 participants
@sanganinamrata @rogyar @sidolov @magento-engcom-team @engcom-Bravo @engcom-Delta @engcom-Dash @engcom-Charlie @engcom-Foxtrot @engcom-Lima