SetFromDate and SetToDate not working correct in 2.4.1 when creating a Rule programatically

[chequille]

Summary (*)

Magento 2.4-develop
I do have a module, where I am generating sales rules programatically. This module worked without andy problems in Magento Version 2.3.5.
No I am testing Version 2.4.1 and found, that SetFromDate and SetToDate is not working correct anymore.

Examples (*)

Here the relevant code lines I am using:

`		$rule =$this->rule;
		$rule->setName($name) // Rules name
		->setDescription('Wertgutschein '.$name )
		->setIsAdvanced(true)
		->setStopRulesProcessing(false)
		->setCustomerGroupIds([0, 1, 2, 3])
		->setWebsiteIds([1])
		->setUseAutoGeneration(0)    // If want to auto generate
		->setCouponType(RuleInterface::COUPON_TYPE_SPECIFIC_COUPON)
		->setSimpleAction(RuleInterface::DISCOUNT_ACTION_FIXED_AMOUNT_FOR_CART)
		->setUsesPerCoupon(1)
		->setDiscountAmount($amount)
		->setFromDate('2020-12-24') //Format YYYY-MM-DD
 		->setToDate('2039-04-14') //Format YYYY-MM-DD
		->setIsActive(true);
		$resultRules = $this->RuleRepository->save($rule);
`

The rule is generated, no problem, but the dates does show the following:

Proposed solution

[m2-assistant]

Hi @chequille. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

✅ Confirmed by @engcom-Delta
Thank you for verifying the issue. Based on the provided information internal tickets MC-40272 were created

Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[gabrieldagama]

Hi @engcom-Delta, can you double-check the dates on the database? We need to understand if this issue is on the presentation layer or not.

Please, also validate if the rules are being applied based on the dates used to create the object.

[m2-assistant]

Hi @engcom-Delta. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
• 2. Verify that the issue is reproducible on 2.4-develop branch
     Details

     - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
     - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
     - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Delta]

Hi @gabrieldagama . Looks like it is not the issue on the presentation layer as we had invalid date value after rule was created:

Manual testing scenario:

• Code snippet for cart rule with Specific Coupon:

		$rule->setName($name) // Rules name
            ->setDescription('Wertgutschein '.$name )
            ->setIsAdvanced(true)
            ->setStopRulesProcessing(false)
            ->setCustomerGroupIds([0, 1, 2, 3])
            ->setWebsiteIds([1])
            ->setUseAutoGeneration(0)    // If want to auto generate
            ->setCouponType(RuleInterface::COUPON_TYPE_SPECIFIC_COUPON)
            ->setSimpleAction(RuleInterface::DISCOUNT_ACTION_FIXED_AMOUNT_FOR_CART)
            ->setUsesPerCoupon(1)
            ->setDiscountAmount($amount)
            ->setFromDate('2020-12-24') //Format YYYY-MM-DD
            ->setToDate('2039-04-14') //Format YYYY-MM-DD
            ->setIsActive(true);
        $ruleCreate = $this->ruleRepository->save($rule);
        //If rule generated, Create new Coupon by rule id
        if ($ruleCreate->getRuleId()) {
            /** @var CouponInterface $coupon */
            $coupon = $this->coupon;
            $coupon->setCode($couponCode)
                ->setIsPrimary(1)
                ->setRuleId($ruleCreate->getRuleId());

            /** @var CouponRepositoryInterface $couponRepository */
            $this->couponRepository->save($coupon);
        }

• Cart rule after creation:
  
  
  

Result:
❌ Coupon code is not valid when try to apply it in shopping cart