[Issue] Catch throwable errors during model save (rollback)

[m2-assistant]

This issue is automatically created based on existing pull request: #32558: Catch throwable errors during model save (rollback)

---

Description (*)

When you throw Error class (or some inherited class) in beforeSave method - Magento do not rollback started transaction correctly.

You can look at similar pull request for OpenMage project: OpenMage/magento-lts#1483

Exception implements Throwable - so this change should be unbreakable

Manual testing scenarios (*)

1. throw new Error('error from some specifiec reason');

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Hi @Sekiphp, Thanks for the report and collaboration!
We have tried to reproduce this issue in Magento 2.4-develop branch and the issue is reproducible. Hence confirming the issue.

We have followed the below steps:

1. Added
   throw new Error('error from some specifiec reason'); In save method
   file path lib/internal/Magento/Framework/Model/ResourceModel/Db/AbstractDb.php
2. Php bin/magento indexer:reindex && php bin/magento cache:flush
3. Refresh Webpage