Wrong method signature

[kassner]

Preconditions

1. Magento 2.4.2-p1;

Steps to reproduce

1. Create an instance of Magento\Sales\Block\Order\Email\Items\DefaultItems;
2. Call the getSku method of the instance passing an Magento\Sales\Model\Order\Item object;

Expected result

1. Get the SKU for the product;

Actual result

1. Error: Call to a member function getProductOptionByCode() on null in /var/www/magento/vendor/magento/module-sales/Block/Order/Email/Items/DefaultItems.php:88

Notes:
Please check the following file for scenario implementation.
Magento/Sales/view/frontend/templates/email/items/order/default.phtml

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @kassner. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[kassner]

Magento\Sales\Model\Order\Item does not have the getOrderItem method, because that's only used in the sub-entities (Creditmemo, Invoice, Shipment).

Quick patch for the issue:

--- vendor/magento/module-sales/Block/Order/Email/Items/DefaultItems.php
+++ vendor/magento/module-sales/Block/Order/Email/Items/DefaultItems.php
@@ -12,6 +12,7 @@
 use Magento\Sales\Model\Order\Creditmemo\Item as CreditmemoItem;
 use Magento\Sales\Model\Order\Invoice\Item as InvoiceItem;
 use Magento\Sales\Model\Order\Item as OrderItem;
+use Magento\Sales\Model\Order\Shipment\Item as ShipmentItem;
 
 /**
  * Sales Order Email items default renderer
@@ -80,12 +81,12 @@
     /**
      * Returns Product SKU for Item provided
      *
-     * @param OrderItem $item
+     * @param OrderItem|CreditmemoItem|InvoiceItem|ShipmentItem $item
      * @return mixed
      */
     public function getSku($item)
     {
-        if ($item->getOrderItem()->getProductOptionByCode('simple_sku')) {
+        if (!($item instanceof OrderItem) && $item->getOrderItem()->getProductOptionByCode('simple_sku')) {
             return $item->getOrderItem()->getProductOptionByCode('simple_sku');
         } else {
             return $item->getSku();

[m2-assistant]

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[m2-assistant]

Hi @engcom-Echo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[groomershop-mt]

This issue is related with: #26010

We have at Magento 2.4.3 exceptions from sales/order/reorder/order_id/123456/ - example:
TypeError: Argument 1 passed to Magento\Framework\DataObject::__construct() must be of the type array, null given, called in /app/m/vendor/magento/module-sales/Model/Reorder/Reorder.php on line 247 and defined in /app/m/vendor/magento/framework/DataObject.php:39
Stack trace:
#0 /app/m/vendor/magento/module-sales/Model/Reorder/Reorder.php(247): Magento\Framework\DataObject->__construct(NULL)
#1 /app/m/vendor/magento/module-sales/Model/Reorder/Reorder.php(208): Magento\Sales\Model\Reorder\Reorder->addItemToCart(Object(Magento\Sales\Model\Order\Item\Interceptor), Object(Magento\Quote\Model\Quote\Interceptor), Object(Magento\Catalog\Model\Product\Interceptor))

[engcom-Echo]

Hi @kassner,
I tried to reproduce the issue you have mentioned with the given steps to reproduce & got the same error mentioned in the issue description. However inorder to confirm on the issue, could you please explain me more regarding the actual scenario in which you are facing the error or the requirement you are trying to achieve.

Thank you

[kassner]

magento2/app/code/Magento/Sales/view/frontend/templates/email/items/order/default.phtml

Lines 9 to 18 in 21aa619

	/** @var $block \Magento\Sales\Block\Order\Email\Items\DefaultItems */
	/** @var $_item \Magento\Sales\Model\Order\Item */
	$_item = $block->getItem();
	$_order = $_item->getOrder();
	?>
	<tr>
	<td class="item-info<?= ($block->getItemOptions() ? ' has-extra' : '') ?>">
	<p class="product-name"><?= $block->escapeHtml($_item->getName()) ?></p>
	<p class="sku"><?= $block->escapeHtml(__('SKU')) ?>: <?= $block->escapeHtml($block->getSku($_item)) ?></p>

[engcom-Echo]

Issue is verified on 2.4-develop branch, with the given steps to reproduce in the issue description.