Skip to content

Fix shipping email replacing with billing email. #35014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from
Open

Fix shipping email replacing with billing email. #35014

wants to merge 4 commits into from

Conversation

pablomishchenko
Copy link

Description (*)

When creating an order out of the guest cart is being done, the shipping email is being replaced by the billing email.
The reason is the absence of checks for the presence of email in the shipping address. The shipping email is always set from the customer email. Added checks for shipping email present and use it for shipping address instead of using customer address.

Fixed Issues (if relevant)

  1. Fixes Shipping Address email field is being replaced with the billing address email #34614

Manual testing scenarios (*)

Precondition: Using REST API of magento

  1. Create a guest Cart using a POST request to this endpoint https://magento.test/rest/default/V1/guest-carts
  2. Add an item to the created guest cart using this endpoint https://magento.test/rest/default/V1/guest-carts/{created-guest-cart-step-1}/items. Example body { "cartItem":{ "sku": "sample-sku", "qty": "1" } }
  3. Add shipping info using a POST request to this endpoint https://magento.test/rest/default/V1/guest-carts/{created-guest-cart-step-1}/shipping-information. Example body
{
  "addressInformation": {
    "billingAddress": {
      "country_id": "FI",
      "street": [ "Testikatu 1 C 44" ],
      "company": "",
      "telephone": "0",
      "postcode": "02230",
      "city": "Espoo",
      "firstname": "Siamak Rahimi Motem",
      "lastname": "Siamak Rahimi Motem",
      "email":"billing@address.co"
  },
  "shippingAddress": {
    "country_id": "FI",
    "street": [ "Testikat" ],
    "company": "",
    "telephone": "0",
    "postcode": "15877",
    "city": "gisha",
    "firstname": "Mona",
    "lastname": "Pourdeljoo",
    "email": "shipping@adress.co",
    "same_as_billing": 0
  },
  "shipping_method_code": "flatrate",
  "shipping_carrier_code": "flatrate",
  "extension_attributes": {}
}}

on this step in table quote_address you can see that addressed have correct emails
image

  1. Make a PUT request to create order endpoint https://magento.test/rest/default/V1/guest-carts/{created-guest-cart-step-1}/order . Example body {"paymentMethod": {"method": "checkmo"}}
  2. Check if sales_order_address table contain correct emails
    image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 24, 2022

Hi @pablomishchenko. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Jan 24, 2022
@pablomishchenko
Copy link
Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@pablomishchenko
Copy link
Author

@magento run WebAPI Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@pablomishchenko
Copy link
Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Quote Component: Sales Priority: P3 May be fixed according to the position in the backlog. Progress: pending review Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shipping Address email field is being replaced with the billing address email
2 participants
@pablomishchenko @magento-engcom-team