Skip to content

Issue #35751 bin/magento config:show fails #35815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from
Open

Issue #35751 bin/magento config:show fails #35815

wants to merge 2 commits into from

Conversation

artskirk
Copy link

Description (*)

I have rewrite \Magento\Config\Model\Config\PathValidator::validate functionality method and use Magento\Config\App\Config\Source\RuntimeConfigSource class to retrieve config value by config path instead of the Magento\Config\Model\Config\Structure , because it returns only paths are declared in module's system.xml.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes bin/magento config:show(or set) design/theme/theme_id fails #35751

Manual testing scenarios (*)

  1. Ran sudo php bin/magento config:show | grep design - displayed saved configuration values:
    design/theme/theme_id - 3
  2. Ran php bin/magento config:show design/theme/theme_id

Expected Result
Will return config value - 3

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 26, 2022

Hi @artskirk. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review labels Jul 26, 2022
@ganeddact
Copy link

I have tried this PR locally, but while a command like this:
bin/magento config:set general/country/default GB
on Magento 2.4.6-p7 returned "value was saved" (without any save on database), after applying this PR I get "The "general/country/default" path doesn't exist. Verify and try again." (probably because it doesn't exist in the database but it's a legit setting that should be allowed to run using the CLI

sheepfy
sheepfy reviewed Feb 4, 2025
View reviewed changes
app/code/Magento/Config/Console/Command/ConfigShowCommand.php
@@ -172,13 +172,11 @@ protected function execute(InputInterface $input, OutputInterface $output)

$configValue = $this->emulatedAreaProcessor->process(function () {
$this->scopeValidator->isValid($this->scope, $this->scopeCode);
$configPath = $this->pathResolver->resolve($this->inputPath, $this->scope, $this->scopeCode);
if ($this->inputPath) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This IF is not longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheepfy sheepfy sheepfy left review comments

Assignees
No one assigned
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bin/magento config:show(or set) design/theme/theme_id fails
3 participants
@artskirk @ganeddact @sheepfy