Skip to content

magento/magento2#35934: Internal Server Error in special-price API Endpoint #37294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

magento/magento2#35934: Internal Server Error in special-price API Endpoint #37294

wants to merge 4 commits into from

Conversation

serbynskyi
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Fixes Internal Server Error in /V1/products/special-price API Endpoint #35934

Manual testing scenarios (*)

  1. Retrieve auth token from the admin endpoint /V1/integration/admin/
  2. Send post request to below endpoints with the payload:
    Payload:
    {"prices": "[]"}

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 24, 2023

Hi @serbynskyi. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Perspective partners-contribution Pull Request is created by Magento Partner labels Mar 24, 2023
@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review labels Mar 24, 2023
@serbynskyi
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@serbynskyi
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@hostep hostep removed their assignment Mar 28, 2023
@serbynskyi
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@serbynskyi serbynskyi requested a review from hostep March 28, 2023 22:13
@serbynskyi
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Hotel
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Hotel engcom-Hotel self-requested a review May 17, 2023 13:41
engcom-Hotel
engcom-Hotel requested changes May 17, 2023
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @serbynskyi,

Thanks for the contribution!

Please fix the Integration and web API test failures.

Thanks

lib/internal/Magento/Framework/Webapi/ServiceInputProcessor.php
@@ -519,6 +520,13 @@ public function convertValue($data, $type)
foreach ($data as $key => $item) {
$result[$key] = $this->_createFromArray($itemType, $item);
}
} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some automated tests with a negative scenario where we are not passing the array.

@sinhaparul sinhaparul added the Project: Community Picked PRs upvoted by the community label May 19, 2023
@engcom-Echo
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Echo
Copy link
Contributor

@serbynskyi
Thank you for your contribution!
While going through the PR, I have found that original scope of the issue was to fix for special-prices but seems the fix is causing regression issue.

Can you please have a look at the integration and Web API test failures those seems to be due the PR changes.

In Order to move PR further build should be green.

@engcom-Echo
Copy link
Contributor

@serbynskyi we are moving this PR On Hold based on comment. Let us know when you are ready to work on it again, and we will be happy to move it back further. Thank you for your contribution.

@engcom-Echo
Copy link
Contributor

@serbynskyi Since it needs changes as per above comment maving it to Draft state.

@engcom-Echo engcom-Echo marked this pull request as draft May 30, 2023 06:23
@engcom-Echo
Copy link
Contributor

As mentioned in above comment since there are regression issues caused by PR changes as we as there are some build failures closing this PR for now.

Please feel free to reopen for any update.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel requested changes

@hostep hostep Awaiting requested review from hostep

Assignees

@engcom-Echo engcom-Echo

@engcom-Hotel engcom-Hotel

Labels
Partner: Perspective partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Project: Community Picked PRs upvoted by the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal Server Error in /V1/products/special-price API Endpoint
6 participants
@serbynskyi @engcom-Hotel @engcom-Echo @hostep @sinhaparul @m2-github-services