Skip to content

[API REST] dataInterfaceName parameter not implemented in endpoint attributeMetadata/customer/custom and attributeMetadata/customerAdress/custom #35944

Open
@jdromerorajoy

Description

@jdromerorajoy

Preconditions and environment

  • Magento version 2.4.5 and older

Steps to reproduce

  1. Open Postman
  2. Send request V1/attributeMetadata/customer/custom with parameter dataInterfaceName (posibles values: \Magento\Customer\Api\Data\CustomerInterface::class or \Magento\Customer\Api\Data\AddressInterface::class)
  3. Send request V1/attributeMetadata/customerAddress/custom with parameter dataInterfaceName (posibles values: \Magento\Customer\Api\Data\CustomerInterface::class or \Magento\Customer\Api\Data\AddressInterface::class)

Expected result

Filter data by dataInterfaceName.

Actual result

No filter data.

Additional information

In the line 93 of the file vendor/magento/module-customer/Model/Metadata/CachedMetadata.php, can see that the parameter it isn't implemented.

image

But the method its filtering by $this->entityType (depending on the requested service).

If the parameter its deprecated, modify the API REST documentation, please.

image

image

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
    Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
    Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
    Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
    Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Activity

m2-assistant

m2-assistant commented on Aug 14, 2022

@m2-assistant

Hi @jdromerorajoy. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

added
Reported on 2.4.5Indicates original Magento version for the Issue report.
Triage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it
on Aug 16, 2022
self-assigned this
on Aug 16, 2022
m2-assistant

m2-assistant commented on Aug 16, 2022

@m2-assistant

Hi @engcom-Echo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
      DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
    1. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

engcom-Echo

engcom-Echo commented on Aug 16, 2022

@engcom-Echo
Contributor

Hello @jdromerorajoy,

Thanks for contribution and collaboration.
As per the code Analysis we have noticed that the parameter $dataObjectClassName is not used in function definition Hence we are confirming the issue.
Steps to reproduced
Please find the attached screen for your reference.

 /**
     * {@inheritdoc}
     */
    public function getCustomAttributesMetadata($dataObjectClassName = null)
    {
        $attributes = $this->attributeMetadataCache->load($this->entityType, 'custom');
        if ($attributes !== false) {
            return $attributes;
        }
        $attributes = $this->metadata->getCustomAttributesMetadata();
        $this->attributeMetadataCache->save($this->entityType, $attributes, 'custom');
        return $attributes;
    }

Thanks

added
Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch
Component: ApiUse with concrete module component label E.g. "Component: Api" + "Catalog"
Issue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmed
on Aug 16, 2022
added
Issue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmed
and removed
Issue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmed
on Aug 17, 2022
github-jira-sync-bot

github-jira-sync-bot commented on Aug 17, 2022

@github-jira-sync-bot

✅ Jira issue https://jira.corp.adobe.com/browse/AC-6411 is successfully created for this GitHub issue.

m2-assistant

m2-assistant commented on Aug 17, 2022

@m2-assistant

✅ Confirmed by @AmyJZhao. Thank you for verifying the issue.
Issue Available: @AmyJZhao, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

removed
Priority: P3May be fixed according to the position in the backlog.
on Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area: APIsComponent: ApiUse with concrete module component label E.g. "Component: Api" + "Catalog"Issue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P3May be fixed according to the position in the backlog.Progress: dev in progressReported on 2.4.5Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchTriage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @jdromerorajoy@AmyJZhao@engcom-Echo@engcom-Hotel@github-jira-sync-bot

      Issue actions

        [API REST] dataInterfaceName parameter not implemented in endpoint attributeMetadata/customer/custom and attributeMetadata/customerAdress/custom · Issue #35944 · magento/magento2