Skip to content

[Issue] Chore: Backup - Replace Block Escaping with Escaper #37100

Open
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #37089: Chore: Backup - Replace Block Escaping with Escaper


Description (*)

Refactors the Magento_Backup module to replace $block escaping functions with $escaper escaping functions.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
    All commits are accompanied by meaningful commit messages
    All new or changed code is covered with unit/integration tests (if applicable)
    README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
    All automated tests passed successfully (all builds are green)

Activity

m2-assistant

m2-assistant commented on Mar 10, 2023

@m2-assistant
Author

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    5. Add label Issue: Confirmed once verification is complete.
    6. Make sure that automatic system confirms that report has been added to the backlog.
engcom-November

engcom-November commented on Mar 10, 2023

@engcom-November
Contributor

Hello @pykettk,

Thanks for the reporting and collaboration!

We have looked into the codebase of the 2.4-develop branch and found that some of the functions are marked as deprecated from the lib/internal/Magento/Framework/View/Element/AbstractBlock.php class and from now on, one should use the function defined in class lib/internal/Magento/Framework/Escaper.php with the same name.

Hence confirming this issue.

Thanks

github-jira-sync-bot

github-jira-sync-bot commented on Mar 10, 2023

@github-jira-sync-bot

✅ Jira issue https://jira.corp.adobe.com/browse/AC-8223 is successfully created for this GitHub issue.

added
Priority: P2A defect with this priority could have functionality issues which are not to expectations.
on Mar 10, 2023
m2-assistant

m2-assistant commented on Mar 10, 2023

@m2-assistant
Author

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area: FrameworkComponent: BackupIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: ready for devReported on 2.4.xIndicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @pykettk@engcom-November@github-jira-sync-bot

      Issue actions

        [Issue] Chore: Backup - Replace Block Escaping with Escaper · Issue #37100 · magento/magento2