Open
Description
This issue is automatically created based on existing pull request: #37089: Chore: Backup - Replace Block Escaping with Escaper
Description (*)
Refactors the Magento_Backup
module to replace $block
escaping functions with $escaper
escaping functions.
Contribution checklist (*)
- Pull request has a meaningful description of its purposeAll commits are accompanied by meaningful commit messagesAll new or changed code is covered with unit/integration tests (if applicable)README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an updateAll automated tests passed successfully (all builds are green)
Activity
m2-assistant commentedon Mar 10, 2023
Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇
Area: XXXXX
label to the ticket, indicating the functional areas it may be related to.2.4-develop
branchDetails
- Add the comment@magento give me 2.4-develop instance
to deploy test instance on Magento infrastructure.- If the issue is reproducible on
2.4-develop
branch, please, add the labelReproduced on 2.4.x
.- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
Issue: Confirmed
once verification is complete.engcom-November commentedon Mar 10, 2023
Hello @pykettk,
Thanks for the reporting and collaboration!
We have looked into the codebase of the 2.4-develop branch and found that some of the functions are marked as deprecated from the
lib/internal/Magento/Framework/View/Element/AbstractBlock.php
class and from now on, one should use the function defined in classlib/internal/Magento/Framework/Escaper.php
with the same name.Hence confirming this issue.
Thanks
github-jira-sync-bot commentedon Mar 10, 2023
✅ Jira issue https://jira.corp.adobe.com/browse/AC-8223 is successfully created for this GitHub issue.
m2-assistant commentedon Mar 10, 2023
✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.