Open
Description
This issue is automatically created based on existing pull request: #37077: Chore: Contact - Replace Block Escaping with Escaper
Description (*)
Refactors the Magento_Contact
module to replace $block
escaping functions with $escaper
escaping functions.
Contribution checklist (*)
- Pull request has a meaningful description of its purposeAll commits are accompanied by meaningful commit messagesAll new or changed code is covered with unit/integration tests (if applicable)README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an updateAll automated tests passed successfully (all builds are green)
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Pull Request In Progress
Activity
engcom-Bravo commentedon Mar 10, 2023
Hello @pykettk,
Thanks for the reporting and collaboration!
We have looked into the codebase of the 2.4-develop branch and find that the function
escapeJs
oflib/internal/Magento/Framework/View/Element/AbstractBlock.php
is marked as deprecated and from now on, should use the function defined in classlib/internal/Magento/Framework/Escaper.php
namedescapeJs
.Hence confirming this issue.
Thanks
github-jira-sync-bot commentedon Mar 10, 2023
✅ Jira issue https://jira.corp.adobe.com/browse/AC-8171 is successfully created for this GitHub issue.
m2-assistant commentedon Mar 10, 2023
✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.