Skip to content

[Issue] Chore: Contact - Replace Block Escaping with Escaper #37112

Open
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #37077: Chore: Contact - Replace Block Escaping with Escaper


Description (*)

Refactors the Magento_Contact module to replace $block escaping functions with $escaper escaping functions.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
    All commits are accompanied by meaningful commit messages
    All new or changed code is covered with unit/integration tests (if applicable)
    README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
    All automated tests passed successfully (all builds are green)

Activity

engcom-Bravo

engcom-Bravo commented on Mar 10, 2023

@engcom-Bravo
Contributor

Hello @pykettk,

Thanks for the reporting and collaboration!

We have looked into the codebase of the 2.4-develop branch and find that the function escapeJs of lib/internal/Magento/Framework/View/Element/AbstractBlock.php is marked as deprecated and from now on, should use the function defined in class lib/internal/Magento/Framework/Escaper.php named escapeJs.

Hence confirming this issue.

Thanks

added
Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch
Issue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmed
Priority: P2A defect with this priority could have functionality issues which are not to expectations.
on Mar 10, 2023
github-jira-sync-bot

github-jira-sync-bot commented on Mar 10, 2023

@github-jira-sync-bot

✅ Jira issue https://jira.corp.adobe.com/browse/AC-8171 is successfully created for this GitHub issue.

m2-assistant

m2-assistant commented on Mar 10, 2023

@m2-assistant
Author

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area: FrameworkComponent: ContactIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: PR in progressReported on 2.4.xIndicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch

    Type

    No type

    Projects

    Status

    Pull Request In Progress

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @pykettk@engcom-Bravo@github-jira-sync-bot

      Issue actions

        [Issue] Chore: Contact - Replace Block Escaping with Escaper · Issue #37112 · magento/magento2