-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Chore: Store - Replace Block Escaping with Escaper #37051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @pykettk. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento create issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @pykettk
Thank you for your contribution here.
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
✔️ QA Passed Preconditions:
Manual testing scenario:
Before: ✖️ Additionally verified:
No additional manual test cases is required as part of regression cycle as this PR is related to the refactoring of the Store module. As multiple builds are failed. Hence, moving this PR to "Extended Testing". |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Description (*)
Refactors the
Magento_Store
module to replace$block
escaping functions with$escaper
escaping functions.Contribution checklist (*)
Resolved issues: