Skip to content

Chore: Grouped Product - Replace Block Escaping with Escaper #37160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Chore: Grouped Product - Replace Block Escaping with Escaper #37160

wants to merge 2 commits into from

Conversation

pykettk
Copy link
Member

@pykettk pykettk commented Mar 9, 2023 •
edited by engcom-Lima
Loading

Description (*)

Refactors the Magento_GroupedProduct module to replace $block escaping functions with $escaper escaping functions.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Chore: Grouped Product - Replace Block Escaping with Escaper #37171: Chore: Grouped Product - Replace Block Escaping with Escaper

@m2-assistant
Copy link

m2-assistant bot commented Mar 9, 2023

Hi @pykettk. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Fisheye partners-contribution Pull Request is created by Magento Partner labels Mar 9, 2023
@pykettk
Copy link
Member Author

pykettk commented Mar 9, 2023

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Mar 9, 2023
Open
6 tasks
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 10, 2023
leonhelmus
leonhelmus approved these changes Mar 18, 2023
View reviewed changes
Copy link

@leonhelmus leonhelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@engcom-Lima engcom-Lima self-assigned this Mar 20, 2023
@engcom-Lima
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Lima
Copy link
Contributor

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop and PHP 8.1

Manual testing scenario:
Verify in the Magento_GroupedProduct module to replaces $block escaping functions with $escaper escaping functions after applying the PR changes.

Before: ✖️
Screenshot 2023-03-20 at 4 33 27 PM

After: ✔️
Screenshot 2023-03-20 at 4 47 26 PM

Additonally tested:

  1. Created the group product and assigned simple product.
  2. After creation verified on frontend by enabling and disabling it.
  3. Created order from the frontend.
  4. Added to the wishlist and added to the cart.

No additional manual test case is required in regression cycle as this PR is related to the refactoring of the codes.

As builds are failed hence, moving this PR to Extended Testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonhelmus leonhelmus leonhelmus approved these changes

Assignees

@leonhelmus leonhelmus

@engcom-Lima engcom-Lima

Labels
Partner: Fisheye partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Chore: Grouped Product - Replace Block Escaping with Escaper
5 participants
@pykettk @engcom-Lima @leonhelmus @magento-devops-reposync-svc @m2-github-services