Skip to content

Improve setup:di:compile performance by using gc_disable #38032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ilnytskyi
Copy link
Contributor

@ilnytskyi ilnytskyi commented Oct 2, 2023

Description (*)

By disabling garbage collector the code generation finishes a bit faster:

  1. Result for this contribution repo
    Selection_755

With larger apps the difference is not that significant but noticeable
2.

  • 2 minutes without changes
    Selection_758

  • under 2 minutes with changes
    Selection_757

I also checked calling gc_collect_cycles after each operation to save some memory, but the difference is not that significant and visible on the second screenshot.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. Run setup:di:compile on different CPUs with and without changes
  2. Compare execution time

Questions or comments

  1. More tests needed on different CPUs.
  2. The actual result may vary per project, depending from number of plugins/factories/proxies needed to detect and generate.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Improve setup:di:compile performance by using gc_disable #38035: Improve setup:di:compile performance by using gc_disable

@m2-assistant
Copy link

m2-assistant bot commented Oct 2, 2023

Hi @ilnytskyi. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@ilnytskyi
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@ihor-sviziev
Copy link
Contributor

@engcom-Hotel
Copy link
Contributor

@magento create issue

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 3, 2023
@ilnytskyi
Copy link
Contributor Author

Is that inspired by composer/composer@ac676f4 https://blog.blackfire.io/performance-impact-of-the-php-garbage-collector.html ?

@ihor-sviziev partially yes. There are other cases where this approach is used like PHPstan https://phpstan.org/blog/phpstan-1-6-0-with-conditional-return-types

@ihor-sviziev
Copy link
Contributor

@engcom-Delta, any updates on testing these changes?

@hostep
Copy link
Contributor

hostep commented Oct 17, 2023

@ihor-sviziev: I believe testing results are availabe on the associated issue: #38035

@engcom-Delta engcom-Delta added Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it and removed Progress: testing in progress labels Nov 15, 2023
@sinhaparul sinhaparul added the Project: Community Picked PRs upvoted by the community label Mar 4, 2024
@engcom-Hotel engcom-Hotel self-assigned this Mar 12, 2024
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel
Copy link
Contributor

❌ QA not Passed

We have tested the functionality of the below command with and without PR changes (on the vanilla instance), but the outcome is almost the same:

time bin/magento setup:di:compile

Please find below the screenshots of the outcome for reference:

Without PR Changes
image

With PR Changes
image

We are using the Mac environment to test this PR. Please review the PR changes and let us know if we missed anything.

Thanks

@engcom-Hotel
Copy link
Contributor

Hi @ilnytskyi,

I trust you've reviewed this comment. We haven't noticed significant differences with or without the PR changes. Kindly reconsider this and inform us if anything has been overlooked.

Thank you.

@engcom-Hotel
Copy link
Contributor

Hello @ilnytskyi,

Thank you for your contribution!

As we have been unable to get any reply from your side for a long time, we are closing this PR for now.

Whenever you are ready to take this up please free to reopen it or ask us to reopen the same. We will be happy to do that.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Project: Community Picked PRs upvoted by the community Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Improve setup:di:compile performance by using gc_disable
6 participants