Skip to content

ui-select not maintaining values in dynamicRows component when actionDelete is invoked #38260

Open
@ioweb-gr

Description

@ioweb-gr

Summary

Add a dynamicRows component inside a ui form and try to use a ui-select element for choosing products for example.

You can select product fine

image

However when deleting the second row, the label is lost from the first one

image

The only way to work around this is to add your own ui-component for this.

From multiple attempts I realized that only the state of the value observable is retained when actionDelete is invoked in all rows of the dynamicRows component.

Examples

<dynamicRows name="receipt_items" sortOrder="10" component="Magento_Ui/js/dynamic-rows/dynamic-rows">
            <settings>
                <addButtonLabel translate="true">Add Item</addButtonLabel>
                <componentType>dynamicRows</componentType>
            </settings>
            <container name="record" component="Magento_Ui/js/dynamic-rows/record">
                <argument name="data" xsi:type="array">
                    <item name="config" xsi:type="array">
                        <item name="isTemplate" xsi:type="boolean">true</item>
                        <item name="is_collection" xsi:type="boolean">true</item>
                        <item name="componentType" xsi:type="string">container</item>
                    </item>
                </argument>
                <field name="product" component="Magento_Ui/js/form/element/ui-select" sortOrder="10" formElement="select">
                    <argument name="data" xsi:type="array">
                        <item name="config" xsi:type="array">
                            <item name="filterOptions" xsi:type="boolean">true</item>
                            <item name="multiple" xsi:type="boolean">false</item>
                            <item name="showCheckbox" xsi:type="boolean">true</item>
                            <item name="disableLabel" xsi:type="boolean">true</item>
                            <item name="levelsVisibility" xsi:type="number">1</item>
                            <item name="searchOptions" xsi:type="boolean">true</item>
                            <item name="searchUrl" xsi:type="url" path="catalog/product/search"/>
                            <item name="filterPlaceholder" xsi:type="string" translate="true">Product Name or SKU</item>
                            <item name="emptyOptionsHtml" xsi:type="string" translate="true">Start typing to find products</item>
                            <item name="missingValuePlaceholder" xsi:type="string" translate="true">Product with ID: %s doesn\'t exist</item>
                        </item>
                    </argument>
                    <settings>
                        <required>false</required>
                        <validation>
                            <rule name="required-entry" xsi:type="boolean">false</rule>
                        </validation>
                        <elementTmpl>ui/grid/filters/elements/ui-select</elementTmpl>
                        <label translate="true">Product</label>
                        <dataScope>data.product</dataScope>
                        <componentType>field</componentType>
                        <listens>
                            <link name="${ $.namespace }.${ $.namespace }:responseData">setParsed</link>
                        </listens>
                    </settings>
                </field>

                <field name="name" sortOrder="20" formElement="input">
                    <!-- ... field configuration ... -->
                </field>
                <field name="sku" sortOrder="30" formElement="input">
                    <!-- ... field configuration ... -->
                </field>
                <field name="quantity" sortOrder="40" formElement="input">
                    <!-- ... field configuration ... -->
                </field>
                <field name="price" sortOrder="50" formElement="input">
                    <!-- ... field configuration ... -->
                </field>
                <actionDelete sortOrder="80">
                    <settings>
                        <dataType>text</dataType>
                        <label translate="true">Actions</label>
                        <additionalClasses>
                            <class name="data-grid-actions-cell">true</class>
                        </additionalClasses>
                        <componentType>actionDelete</componentType>
                    </settings>
                </actionDelete>
            </container>
        </dynamicRows>

Proposed solution

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
    Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
    Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
    Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
    Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Activity

added
Triage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it
on Dec 9, 2023
m2-assistant

m2-assistant commented on Dec 9, 2023

@m2-assistant

Hi @ioweb-gr. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

m2-assistant

m2-assistant commented on Dec 12, 2023

@m2-assistant

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    5. Add label Issue: Confirmed once verification is complete.
    6. Make sure that automatic system confirms that report has been added to the backlog.
engcom-November

engcom-November commented on Dec 12, 2023

@engcom-November
Contributor

Hello @ioweb-gr,

Thank you for the report and collaboration!

We were able to reproduce this issue on 2.4-develop.
Please take a look at the screenshot below:
image

When deleting one of the row with or without any product selected, we get the below result
image
Hence confirming this issue.

Please find the custom module used to reproduce this issue.
UiComponentVendor.zip

Thank you.

github-jira-sync-bot

github-jira-sync-bot commented on Dec 12, 2023

@github-jira-sync-bot

✅ Jira issue https://jira.corp.adobe.com/browse/AC-10675 is successfully created for this GitHub issue.

m2-assistant

m2-assistant commented on Dec 12, 2023

@m2-assistant

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

6 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area: Admin UIComponent: UiIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: ready for devReported on 2.4.xIndicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchTriage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @ioweb-gr@engcom-Bravo@engcom-November@github-jira-sync-bot

        Issue actions

          ui-select not maintaining values in dynamicRows component when actionDelete is invoked · Issue #38260 · magento/magento2