Skip to content

Updated Db.php and Dbp.php #33183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 18 commits into from
Closed

Updated Db.php and Dbp.php #33183

wants to merge 18 commits into from

Conversation

manavluhar
Copy link
Contributor

@manavluhar manavluhar commented Jun 8, 2021 •
edited by m2-assistant bot
Loading

Description (*)

Changed Exception message from Wrong "$connection" parametr to Wrong "$connection" parameter as parameter word is more meaning full compare to parametr

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Updated Db.php and Dbp.php #38340: Updated Db.php and Dbp.php

@m2-assistant
Copy link

m2-assistant bot commented Jun 8, 2021

Hi @manavluhar. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@manavluhar
Update Db.php
4a3c64a 
Changed Exception Message from Wrong "$connection" parametr to Wrong "$connection" parameter. as parameter word is more meaning full compare to parametr

Update Dbp.php

Changed Exception Message from Wrong "$connection" parametr to Wrong "$connection" parameter. as parameter word is more meaning full compare to parametr
@manavluhar
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@gabrieldagama gabrieldagama added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Jun 10, 2021
@ihor-sviziev ihor-sviziev self-assigned this Jul 1, 2021
@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests EE, Unit Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix labels Jul 1, 2021
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-9138 has been created to process this Pull Request

@manavluhar
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@manavluhar
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@manavluhar
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@manavluhar manavluhar closed this Oct 23, 2024
@manavluhar manavluhar reopened this Oct 23, 2024
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Oct 23, 2024

Hi @manavluhar. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@manavluhar
Copy link
Contributor Author

@magento run all tests

@manavluhar
Copy link
Contributor Author

@magento run Static Tests,Functional Tests B2B

@manavluhar
Copy link
Contributor Author

@engcom-Delta @engcom-Charlie Now this PR is ready to merge.

@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Oct 28, 2024 •
edited
Loading

Hi @manavluhar,

Please fix the static and Functional B2B failures.

As mention here, we are not able to update this branch so kindly do the needful in order to proceed on this PR.
image

Thank you!

@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Nov 13, 2024
@engcom-Charlie
Copy link
Contributor

It seems that bot moved it to to testing hence moving back to Extended Testing again.

@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Nov 14, 2024 •
edited
Loading

Hi @manavluhar,

As we have mentioned here, we are still unable to update the PR branch.

In order to proceed further on this PR, we need a green build. Since we dont have permission on the branch kindly fix the Static and Functional Test B2B. Till then moving this PR to On Hold status.

Thank you!

@manavluhar
Copy link
Contributor Author

@magento run all tests

@engcom-Charlie
Copy link
Contributor

Hi @manavluhar,

As mentioned here, can you please fix Static and B2B failures, as we are not abel to access your repository.

Thank you!

@manavluhar
Copy link
Contributor Author

@engcom-Charlie This related to author name of perticuler development as I see. Are we suppose to remove author's name from the files I commited?
image

@engcom-Charlie
Copy link
Contributor

@engcom-Charlie This related to author name of perticuler development as I see. Are we suppose to remove author's name from the files I commited? image

Yes @manavluhar, you can remove the @author tag from the mentioned test failure as Magento 2 coding standards prohibit the use of the @author tag in docblocks.

@manavluhar
Copy link
Contributor Author

@magento run all tests

@manavluhar
Copy link
Contributor Author

@magento run all tests

@manavluhar
Copy link
Contributor Author

@magento run all tests

@manavluhar
Copy link
Contributor Author

@magento run Static Tests, Functional Tests B2B

@engcom-Charlie
Copy link
Contributor

Hi @manavluhar,

As mentioned, can you please fix Static and B2B failures, as we are not abel to access your repository.

Thank you!

@engcom-Charlie
Copy link
Contributor

@manavluhar, as mentioned here, we are not able to proceed further on this PR as we don't have access to your repository. Hence closing this PR now.

Please feel free to reopen if you are done with the fixes.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Data Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: ready for testing Project: Community Picked PRs upvoted by the community Release Line: 2.4 Risk: low
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Updated Db.php and Dbp.php
10 participants
@manavluhar @ihor-sviziev @magento-engcom-team @engcom-Delta @engcom-Echo @engcom-Charlie @mrtuvn @gabrieldagama @engcom-November @Priyakshic